Skip to content

OSDOCS#12643: Docs for BYO OIDC auth provider #93779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented May 27, 2025

Version(s):
4.19

Issue:
https://issues.redhat.com/browse/OSDOCS-12643

Link to docs preview:
https://93779--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html

QE review:

  • QE has approved this change.

Additional information:

@bergerhoffer bergerhoffer changed the title OSDOCS#12643: Docs for BYO OIDC auth provider [WIP] OSDOCS#12643: Docs for BYO OIDC auth provider May 27, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@bergerhoffer bergerhoffer added this to the Planned for 4.19 GA milestone May 27, 2025
@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 27, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 27, 2025

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 27, 2025
@bergerhoffer bergerhoffer force-pushed the OSDOCS-12643-oidc branch 5 times, most recently from d4b868b to 119c227 Compare May 27, 2025 22:56
@bergerhoffer bergerhoffer force-pushed the OSDOCS-12643-oidc branch 2 times, most recently from 77d6e30 to 07f266f Compare June 4, 2025 18:21
@bergerhoffer
Copy link
Contributor Author

@xingxingxia I worked on some updates to try to address the whole complications what kind of kubeconfig file (or other long-lived method of logging in) that they need.

Here is the diff: https://github.com/openshift/openshift-docs/compare/77d6e302898e243b43e67f118def6eebbfdc21cf..07f266fd1eb0ee33350890579aade6f2ebd3e841

Let me know what you think of the changes.

@xingxingxia
Copy link
Contributor

@bergerhoffer LGTM from QE perspective except above two final issues.

@bergerhoffer bergerhoffer force-pushed the OSDOCS-12643-oidc branch 2 times, most recently from 7726be4 to cf54970 Compare June 5, 2025 14:38
@liouk
Copy link
Member

liouk commented Jun 5, 2025

@bergerhoffer LGTM as well 👍

@xingxingxia
Copy link
Contributor

Final updates are great
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2025
Copy link

openshift-ci bot commented Jun 6, 2025

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xiuwang
Copy link

xiuwang commented Jun 9, 2025

Final updates are great
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@bergerhoffer bergerhoffer merged commit eb74085 into openshift:main Jun 9, 2025
2 checks passed
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #94427

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants