-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#12643: Docs for BYO OIDC auth provider #93779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Fri Jun 06 19:08:15 - Prow CI generated the docs preview: https://93779--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html |
446f788
to
b2b5f8f
Compare
d4b868b
to
119c227
Compare
77d6e30
to
07f266f
Compare
@xingxingxia I worked on some updates to try to address the whole complications what kind of kubeconfig file (or other long-lived method of logging in) that they need. Here is the diff: https://github.com/openshift/openshift-docs/compare/77d6e302898e243b43e67f118def6eebbfdc21cf..07f266fd1eb0ee33350890579aade6f2ebd3e841 Let me know what you think of the changes. |
@bergerhoffer LGTM from QE perspective except above two final issues. |
7726be4
to
cf54970
Compare
@bergerhoffer LGTM as well 👍 |
Final updates are great |
cf54970
to
cc43aaf
Compare
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Final updates are great |
/cherrypick enterprise-4.19 |
@bergerhoffer: new pull request created: #94427 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.19
Issue:
https://issues.redhat.com/browse/OSDOCS-12643
Link to docs preview:
https://93779--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html
QE review:
Additional information: