-
Notifications
You must be signed in to change notification settings - Fork 416
OCPBUGS-60903: oc adm release extract: add oc-mirror to the tools list #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPBUGS-60903: oc adm release extract: add oc-mirror to the tools list #2106
Conversation
This will allow oc-mirror to be injected with the OCP release version it's a part of.
@r4f4: This pull request references Jira Issue OCPBUGS-60903, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @joepvd |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
…ols list Openshift -> OpenShift typo
To learn more about OpenShift, visit [docs.openshift.com](https://docs.openshift.com) | ||
and select the version of OpenShift you are using. | ||
# Installing the tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should be Installing the Tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied from the other instances which are all "Installing the tools" but I can change it, no problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, anyway. You can just keep it to be consistent.
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This will allow oc-mirror to be injected with the OCP release version it's a part of.