Improve Makefile performance and reduce spurious bundle changes #1984
Conversation
Change that makes rebase of oadp-operator possible:
- Make `make help` instant by deferring CLUSTER_TYPE evaluation to runtime
(was 12s, now 0.06s - 200x faster)
- Move cloud-specific variables to test-e2e targets to avoid parse-time
cluster API calls that hang when not connected
- Preserve createdAt timestamp in CSV when only timestamp changed
- Suppress tool version check warnings when binaries don't exist yet
- Make container tool check lazy (only runs when needed)
- Clean up commented code with concise explanatory notes
Signed-off-by: Michal Pryc <[email protected]>
Co-Authored-By: Claude <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| OLD_CREATEDAT=$$(grep '^ createdAt: ' /tmp/oadp-old-csv.yaml); \ | ||
| NEW_CREATEDAT=$$(grep '^ createdAt: ' bundle/manifests/oadp-operator.clusterserviceversion.yaml); \ | ||
| cp bundle/manifests/oadp-operator.clusterserviceversion.yaml /tmp/oadp-new-csv-with-old-timestamp.yaml; \ | ||
| $(SED) -i "s/^ createdAt: .*/$$OLD_CREATEDAT/" /tmp/oadp-new-csv-with-old-timestamp.yaml; \ |
There was a problem hiding this comment.
Just noting that sed -i would work here only with gsed on macos hence the prior > + mv
Lines 422 to 438 in b9229e4
There was a problem hiding this comment.
Anyone w macos once installing gsed should be good to go.
There was a problem hiding this comment.
@kaovilai that part was not chaged (discovery of SED on MacOS X), could you please check if the reworked Makefile requires some changes to work in it, or we are fine here?
|
@mpryc: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Change that makes rebase of oadp-operator possible:
make helpinstant by deferring CLUSTER_TYPE evaluation to runtime (was 12s, now 0.06s - 200x faster)Why the changes were made
To allow rebasebot properly run $ make bundle, without access to the cluster.
Without this change it's impossible to update manifests without being logged to the cluster.
How to test the changes made
Reading Makefile, asking right questions to claude and modifying code by hand + testing with few make targets:
$ make help
$ make manifests
$ make build
$ make bundle
$ make deploy-olm
$ make run
$ make install
$ make undeploy-olm
$ make uninstall
Tests should be performed by prow CI to execute some other make targets.