Skip to content

Conversation

@DavidRajnoha
Copy link
Contributor

Contains fixes that were necessary to make the testsuite integrated in the release pipeline work.

Add CYPRESS_COO_NAMESPACE environment variable to enable flexible namespace configuration for Cluster Observability Operator installations. This allows testing with different namespace configurations (e.g., 'coo' instead of the default 'openshift-cluster-observability-operator').

Additionally, it makes the cleanup delete commands not fail when the deleted resources is not present, which is expected as they are run before the tests to ensure clean environment.

Changes:

  • Add CYPRESS_COO_NAMESPACE env var with default value 'openshift-cluster-observability-operator'
  • Update cypress.config.ts to read the new environment variable
  • Update configure-env.sh to prompt for and export namespace configuration
  • Update coo_stage.sh installation script to use configurable namespace
  • Update all test files to use Cypress.env('COO_NAMESPACE') instead of hardcoded values
  • Update mock generators to use the env var for namespace
  • Add --ignore-not-found flag to all oc delete commands in cleanup functions
  • Update dashboard management to use sed for on-the-fly namespace substitution
  • Add documentation in README.md for the new configuration option

…bustness

Add CYPRESS_COO_NAMESPACE environment variable to enable flexible namespace
configuration for Cluster Observability Operator installations. This allows
testing with different namespace configurations (e.g., 'coo' instead of the
default 'openshift-cluster-observability-operator').

Changes:
- Add CYPRESS_COO_NAMESPACE env var with default value 'openshift-cluster-observability-operator'
- Update cypress.config.ts to read the new environment variable
- Update configure-env.sh to prompt for and export namespace configuration
- Update coo_stage.sh installation script to use configurable namespace
- Update all test files to use Cypress.env('COO_NAMESPACE') instead of hardcoded values
- Update mock generators to use the env var for namespace
- Add --ignore-not-found flag to all oc delete commands in cleanup functions
- Update dashboard management to use sed for on-the-fly namespace substitution
- Add documentation in README.md for the new configuration option

Benefits:
- Enables testing against different namespace configurations
- Makes cleanup operations idempotent (won't fail if resources don't exist)
- Improves flexibility for release pipeline testing
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2025

@DavidRajnoha: This pull request references OBSINTA-858 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Contains fixes that were necessary to make the testsuite integrated in the release pipeline work.

Add CYPRESS_COO_NAMESPACE environment variable to enable flexible namespace configuration for Cluster Observability Operator installations. This allows testing with different namespace configurations (e.g., 'coo' instead of the default 'openshift-cluster-observability-operator').

Additionally, it makes the cleanup delete commands not fail when the deleted resources is not present, which is expected as they are run before the tests to ensure clean environment.

Changes:

  • Add CYPRESS_COO_NAMESPACE env var with default value 'openshift-cluster-observability-operator'
  • Update cypress.config.ts to read the new environment variable
  • Update configure-env.sh to prompt for and export namespace configuration
  • Update coo_stage.sh installation script to use configurable namespace
  • Update all test files to use Cypress.env('COO_NAMESPACE') instead of hardcoded values
  • Update mock generators to use the env var for namespace
  • Add --ignore-not-found flag to all oc delete commands in cleanup functions
  • Update dashboard management to use sed for on-the-fly namespace substitution
  • Add documentation in README.md for the new configuration option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidRajnoha
Copy link
Contributor Author

The release pipeline tests for incidents are running from a branch from my fork, therefore it is not necessary to merge this immediately.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@DavidRajnoha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 2cff039 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@etmurasaki
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidRajnoha, etmurasaki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@DavidRajnoha
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@DavidRajnoha
Copy link
Contributor Author

DavidRajnoha commented Nov 13, 2025

There are few fixes that I realized I have not introduced and I would like to merge together.

@etmurasaki
Copy link
Contributor

@DavidRajnoha please, resolve the conflict.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2025
@etmurasaki
Copy link
Contributor

/label qe-approved
/label ux-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2025

@DavidRajnoha: This pull request references OBSINTA-858 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Contains fixes that were necessary to make the testsuite integrated in the release pipeline work.

Add CYPRESS_COO_NAMESPACE environment variable to enable flexible namespace configuration for Cluster Observability Operator installations. This allows testing with different namespace configurations (e.g., 'coo' instead of the default 'openshift-cluster-observability-operator').

Additionally, it makes the cleanup delete commands not fail when the deleted resources is not present, which is expected as they are run before the tests to ensure clean environment.

Changes:

  • Add CYPRESS_COO_NAMESPACE env var with default value 'openshift-cluster-observability-operator'
  • Update cypress.config.ts to read the new environment variable
  • Update configure-env.sh to prompt for and export namespace configuration
  • Update coo_stage.sh installation script to use configurable namespace
  • Update all test files to use Cypress.env('COO_NAMESPACE') instead of hardcoded values
  • Update mock generators to use the env var for namespace
  • Add --ignore-not-found flag to all oc delete commands in cleanup functions
  • Update dashboard management to use sed for on-the-fly namespace substitution
  • Add documentation in README.md for the new configuration option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the ux-approved Signifies that UX has signed off on this PR label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. qe-approved Signifies that QE has signed off on this PR ux-approved Signifies that UX has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants