-
Notifications
You must be signed in to change notification settings - Fork 35
OBSINTA-858: configurable Cypress COO namespace and idempotent cleanup #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OBSINTA-858: configurable Cypress COO namespace and idempotent cleanup #633
Conversation
…bustness
Add CYPRESS_COO_NAMESPACE environment variable to enable flexible namespace
configuration for Cluster Observability Operator installations. This allows
testing with different namespace configurations (e.g., 'coo' instead of the
default 'openshift-cluster-observability-operator').
Changes:
- Add CYPRESS_COO_NAMESPACE env var with default value 'openshift-cluster-observability-operator'
- Update cypress.config.ts to read the new environment variable
- Update configure-env.sh to prompt for and export namespace configuration
- Update coo_stage.sh installation script to use configurable namespace
- Update all test files to use Cypress.env('COO_NAMESPACE') instead of hardcoded values
- Update mock generators to use the env var for namespace
- Add --ignore-not-found flag to all oc delete commands in cleanup functions
- Update dashboard management to use sed for on-the-fly namespace substitution
- Add documentation in README.md for the new configuration option
Benefits:
- Enables testing against different namespace configurations
- Makes cleanup operations idempotent (won't fail if resources don't exist)
- Improves flexibility for release pipeline testing
|
@DavidRajnoha: This pull request references OBSINTA-858 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The release pipeline tests for incidents are running from a branch from my fork, therefore it is not necessary to merge this immediately. |
|
@DavidRajnoha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidRajnoha, etmurasaki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
There are few fixes that I realized I have not introduced and I would like to merge together. |
|
@DavidRajnoha please, resolve the conflict. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label qe-approved |
|
@DavidRajnoha: This pull request references OBSINTA-858 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contains fixes that were necessary to make the testsuite integrated in the release pipeline work.
Add CYPRESS_COO_NAMESPACE environment variable to enable flexible namespace configuration for Cluster Observability Operator installations. This allows testing with different namespace configurations (e.g., 'coo' instead of the default 'openshift-cluster-observability-operator').
Additionally, it makes the cleanup delete commands not fail when the deleted resources is not present, which is expected as they are run before the tests to ensure clean environment.
Changes: