Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-5282: Fix default config + test #4439

Merged
merged 5 commits into from
Jan 28, 2025
Merged

USHIFT-5282: Fix default config + test #4439

merged 5 commits into from
Jan 28, 2025

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jan 20, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-5282 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 January 20, 2025 16:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@pmtk pmtk force-pushed the fix-cfg branch 3 times, most recently from 182f0c9 to c890883 Compare January 21, 2025 09:23
@pmtk pmtk marked this pull request as draft January 21, 2025 09:23
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@pmtk
Copy link
Member Author

pmtk commented Jan 21, 2025

/test e2e-aws-tests

1 similar comment
@pmtk
Copy link
Member Author

pmtk commented Jan 21, 2025

/test e2e-aws-tests

@pmtk
Copy link
Member Author

pmtk commented Jan 21, 2025

/test verify e2e-aws-tests

@pmtk pmtk marked this pull request as ready for review January 21, 2025 15:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@openshift-ci openshift-ci bot requested a review from agullon January 21, 2025 15:10
@pmtk
Copy link
Member Author

pmtk commented Jan 24, 2025

/retest

pacevedom
pacevedom approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e87b992 and 2 for PR HEAD 8162a0b in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7eb7ab6 into openshift:main Jan 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacevedom pacevedom pacevedom approved these changes

@copejon copejon Awaiting requested review from copejon

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@agullon agullon Awaiting requested review from agullon

Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmtk @openshift-ci-robot @pacevedom