[release-4.17] After OCL is enabled few phases in MCN are not updating as expected

[dkhater-redhat]

- What I did
Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
- How to verify it

1. Enable OCL on a cluster
2. Apply a MachineConfig change
3. Watch oc get machineconfignode -w -o wide
4. Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL
   - Description for the changelog

[openshift-ci-robot]

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-43435, which is invalid:

• expected the bug to target the "4.17.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-43435 to depend on a bug targeting a version in 4.18.0, 4.18.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
- How to verify it

1. Enable OCL on a cluster
2. Apply a MachineConfig change
3. Watch oc get machineconfignode -w -o wide
4. Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL
   - Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkhater-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dkhater-redhat]

/test unit

[dkhater-redhat]

/test unit

[isabella-janssen]

/hold

Need confirmation on affected versions: https://issues.redhat.com/browse/OCPBUGS-43435?focusedId=28890040&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28890040

[dkhater-redhat]

when ocl is being enable and the image is rolling out to the node, these are the MCN conditions

❯ oc get machineconfignode -o wide -w
NAME                                         UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATECOMPATIBLE   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   RELOADEDCRIO   UNCORDONEDNODE
ip-10-0-111-130.us-west-1.compute.internal   True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          False                      False            False     True               Unknown             True           True          False          False          False
ip-10-0-25-175.us-west-1.compute.internal    True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-35-191.us-west-1.compute.internal    True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-9-211.us-west-1.compute.internal     True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-93-34.us-west-1.compute.internal     True      False            False            False                      False            True      False              False               False          False         False          False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            False     True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            False     True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            False     True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            False     True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       False            True      True               Unknown             True           True          True           False          False
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       True             True      True               Unknown             True           True          True           False          True
ip-10-0-13-219.us-west-1.compute.internal    False     True             Unknown          True                       True             True      True               Unknown             True           True          True           False          True
ip-10-0-13-219.us-west-1.compute.internal    True      False            False            False                      False            False     False              False               False          False         False          False          False

[openshift-ci-robot]

@dkhater-redhat: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

- What I did
Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.
- How to verify it

1. Enable OCL on a cluster
2. Apply a MachineConfig change
3. Watch oc get machineconfignode -w -o wide
4. Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL
   - Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dkhater-redhat]

/retest-required

[openshift-ci]

@dkhater-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-upgrade	a51ceed	link	true	/test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.