CORS-3849,OCPBUGS-76279: Enable hosts plugin within the CoreDNS Corefile for cloud platforms by sadasu · Pull Request #5569 · openshift/machine-config-operator

sadasu · 2026-01-19T18:24:56Z

Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loaded and served via the DNS service provided by the cluster's coreDNS instance. Used CoreDNS documentation [0] for reference.

Please note that the hosts plugin was already enabled in the CoreFile for the cluster CoreDNS instance (as opposed to the bootstrap CoreDNS instance). Only some entries were loaded. After this change, all entries from the /etc/hosts file would be loaded and served by CoreDNS.

This feature was requested by ARO but we feel that the hosts plugin should be enabled on all cloud platforms (GCP, AWS and Azure) at all times and not just when run within ARO.

[0] - https://coredns.io/plugins/hosts/#examples

openshift-ci-robot · 2026-01-19T18:25:00Z

@sadasu: This pull request references CORS-3849 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loadede and served via the DNS service provided by the cluster's coreDNS instance.

Please note that the hosts plugin was already enabled in the CoreFile for the cluster CoreDNS instance (as opposed to the bootstrap CoreDNS instance). Only some entries were loaded. After this change, all entries from the /etc/hosts file would be loaded and served by CoreDNS.

This feature was requested by ARO but we feel that the hosts plugin should be enabled on all cloud platforms (GCP, AWS and Azure) at all times and not just when run within ARO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

zaneb · 2026-01-22T00:19:21Z

/lgtm

sadasu · 2026-01-22T00:47:17Z

/test e2e-gcp-op-ocl

openshift-ci · 2026-01-22T01:00:48Z

New changes are detected. LGTM label has been removed.

shaheen0b111

Small syntax change requested as per the hosts plugin doc

shaheen0b111 · 2026-01-28T07:17:21Z

manifests/cloud-platform-alt-dns/coredns-corefile.tmpl

        match ^api-int.{{ .ControllerConfig.DNS.Spec.BaseDomain }}
        fallthrough
    }
+    {


I think as per the document for hosts plugin , the syntax should be as below

hosts { fallthrough }

shaheen0b111 · 2026-01-28T07:27:44Z

templates/common/cloud-platform-alt-dns/files/coredns-corefile.yaml

            {{- end }}`}}
            fallthrough
        }
+        {


@sadasu , Here also same syntax change as mentioned in another template.

Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loadede and served via the DNS service provided by the cluster's coreDNS instance.

openshift-ci-robot · 2026-02-05T16:57:33Z

@sadasu: This pull request references CORS-3849 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loaded and served via the DNS service provided by the cluster's coreDNS instance. Used CoreDNS documentation [0] for reference.

Please note that the hosts plugin was already enabled in the CoreFile for the cluster CoreDNS instance (as opposed to the bootstrap CoreDNS instance). Only some entries were loaded. After this change, all entries from the /etc/hosts file would be loaded and served by CoreDNS.

This feature was requested by ARO but we feel that the hosts plugin should be enabled on all cloud platforms (GCP, AWS and Azure) at all times and not just when run within ARO.

[0] - https://coredns.io/plugins/hosts/#examples

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2026-02-05T17:24:58Z

/retitle CORS-3849,OCPBUGS-76279: Enable hosts plugin within the CoreDNS Corefile for cloud platforms

openshift-ci-robot · 2026-02-05T17:25:20Z

@sadasu: This pull request references CORS-3849 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

This pull request references Jira Issue OCPBUGS-76279, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Update the CoreDNS Corefile for cloud platforms to enable the hosts plugin. the hosts plugin was enabled within the cluster's Corefile specifically for Node addresses. This change enables all enrties within the /etc/hosts file to be loaded and served via the DNS service provided by the cluster's coreDNS instance. Used CoreDNS documentation [0] for reference.

Please note that the hosts plugin was already enabled in the CoreFile for the cluster CoreDNS instance (as opposed to the bootstrap CoreDNS instance). Only some entries were loaded. After this change, all entries from the /etc/hosts file would be loaded and served by CoreDNS.

This feature was requested by ARO but we feel that the hosts plugin should be enabled on all cloud platforms (GCP, AWS and Azure) at all times and not just when run within ARO.

[0] - https://coredns.io/plugins/hosts/#examples

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-02-05T21:21:04Z

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift	`e839553`	link	true	`/test e2e-hypershift`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

shaheen0b111

After syntax changes, it LGTM

openshift-ci · 2026-02-06T03:01:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadasu, shaheen0b111, zaneb
Once this PR has been reviewed and has the lgtm label, please assign isabella-janssen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2026

openshift-ci bot requested review from dkhater-redhat and umohnani8 January 19, 2026 18:26

openshift-ci bot assigned zaneb Jan 22, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026

sadasu force-pushed the hosts-plugin-cloud-platforms branch from 484ae32 to 3b9e9db Compare January 22, 2026 01:00

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026

shaheen0b111 suggested changes Jan 28, 2026

View reviewed changes

sadasu force-pushed the hosts-plugin-cloud-platforms branch from 3b9e9db to e839553 Compare February 5, 2026 16:55

openshift-ci bot changed the title ~~CORS-3849: Enable hosts plugin within the CoreDNS Corefile for cloud platforms~~ CORS-3849,OCPBUGS-76279: Enable hosts plugin within the CoreDNS Corefile for cloud platforms Feb 5, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 5, 2026

openshift-ci bot requested a review from sergiordlr February 5, 2026 17:25

shaheen0b111 approved these changes Feb 6, 2026

View reviewed changes

Conversation

sadasu commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 19, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zaneb commented Jan 22, 2026

Uh oh!

sadasu commented Jan 22, 2026

Uh oh!

openshift-ci bot commented Jan 22, 2026

Uh oh!

shaheen0b111 left a comment

Choose a reason for hiding this comment

Uh oh!

shaheen0b111 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

shaheen0b111 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Feb 5, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasu commented Feb 5, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 5, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 5, 2026

Uh oh!

shaheen0b111 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sadasu commented Jan 19, 2026 •

edited

Loading

openshift-ci-robot commented Jan 19, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 5, 2026 •

edited by openshift-ci bot

Loading

sadasu commented Feb 5, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 5, 2026 •

edited by openshift-ci bot

Loading