Skip to content

[release-4.20] OCPBUGS-66260: Set -fin timeouts in HAProxy config #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 19, 2026
Merged

[release-4.20] OCPBUGS-66260: Set -fin timeouts in HAProxy config #5459

openshift-merge-bot merged 1 commit into from
Jan 19, 2026

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 2, 2025

This is an automated cherry-pick of #5310

/assign cybertron

/cherrypick release-4.19 release-4.18 release-4.17

@cybertron
OCPBUGS-62232: Set -fin timeouts in HAProxy config
25e44b1 
We have a bug where misbehaved clients are exhausting the connection
limits by starting a connection and abandoning it before it is even
established. Setting the client-fin timeout is a recommended option
to address this sort of situation. This patch also sets server-fin
in the interest of symmetry and avoiding any similar issues on the
server side.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 2, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-62232 has been cloned as Jira Issue OCPBUGS-66260. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-66260: Set -fin timeouts in HAProxy config

Details

In response to this:

This is an automated cherry-pick of #5310

/assign cybertron

/cherrypick release-4.19 release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-62232: Set -fin timeouts in HAProxy config [release-4.20] OCPBUGS-66260: Set -fin timeouts in HAProxy config Dec 2, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 2, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-66260, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #5310

/assign cybertron

/cherrypick release-4.19 release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cybertron
Copy link
Member

cybertron commented Dec 2, 2025

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 2, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 25e44b1 link false /test e2e-openstack
ci/prow/bootstrap-unit 25e44b1 link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cybertron
Copy link
Member

cybertron commented Dec 2, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 2, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@cybertron: This pull request references Jira Issue OCPBUGS-66260, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-62232 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-62232 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @rbbratta

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from rbbratta December 2, 2025 22:17
@rbbratta
Copy link
Contributor

rbbratta commented Dec 3, 2025

/verified later @rbbratta

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 3, 2025

@rbbratta: This PR has been marked to be verified later by @rbbratta.

Details

In response to this:

/verified later @rbbratta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander haircommander mentioned this pull request Jan 13, 2026
Merged
@dkhater-redhat
Copy link
Contributor

dkhater-redhat commented Jan 19, 2026

/lgtm

good work!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, dkhater-redhat, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 8ec7a60 into openshift:release-4.20 Jan 19, 2026
14 of 16 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@openshift-cherrypick-robot: Jira Issue OCPBUGS-66260: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-66260 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #5310

/assign cybertron

/cherrypick release-4.19 release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Jan 19, 2026

@openshift-cherrypick-robot: new pull request created: #5570

Details

In response to this:

This is an automated cherry-pick of #5310

/assign cybertron

/cherrypick release-4.19 release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 19, 2026
Open
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jan 21, 2026

Fix included in accepted release 4.20.0-0.nightly-2026-01-20-183352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mkowalski mkowalski Awaiting requested review from mkowalski

@rbbratta rbbratta Awaiting requested review from rbbratta

Assignees

@cybertron cybertron

@rbbratta rbbratta

@eurijon eurijon

@lyman9966 lyman9966

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@imatza-rh imatza-rh

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.