OCPEDGE-2348: feat(controller): Add Static/Dynamic Device Discovery Mode

[qJkee]

Introduces deviceDiscoveryPolicy field to DeviceClass allowing users to choose between Static and Dynamic device discovery modes:

• Static: VG is created with devices discovered at install time, then discovery is disabled. New devices added later are ignored.
• Dynamic: Devices are continuously discovered and added (existing behavior)

[openshift-ci-robot]

@qJkee: This pull request references OCPEDGE-2348 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Introduces deviceDiscoveryPolicy field to DeviceClass allowing users to choose between Static and Dynamic device discovery modes:

• Static: VG is created with devices discovered at install time, then discovery is disabled. New devices added later are ignored.
• Dynamic: Devices are continuously discovered and added (existing behavior)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [qJkee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

❌ Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.40%. Comparing base (0561e12) to head (cc0361b).
⚠️ Report is 62 commits behind head on main.

Files with missing lines	Patch %	Lines
api/v1alpha1/lvmcluster_webhook.go	64.70%	3 Missing and 3 partials ⚠️
...controllers/lvmcluster/resource/lvm_volumegroup.go	0.00%	5 Missing ⚠️
internal/controllers/vgmanager/controller.go	80.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
+ Coverage   48.11%   48.40%   +0.29%     
==========================================
  Files          52       52              
  Lines        3735     3768      +33     
==========================================
+ Hits         1797     1824      +27     
- Misses       1782     1786       +4     
- Partials      156      158       +2     

Files with missing lines	Coverage Δ
api/v1alpha1/lvmcluster_types.go	100.00% <ø> (ø)
api/v1alpha1/lvmvolumegroup_types.go	100.00% <ø> (ø)
internal/controllers/vgmanager/filter/filter.go	83.33% <100.00%> (+1.90%)	⬆️
internal/controllers/vgmanager/status.go	86.44% <100.00%> (+0.47%)	⬆️
internal/controllers/vgmanager/controller.go	67.22% <80.00%> (+0.84%)	⬆️
...controllers/lvmcluster/resource/lvm_volumegroup.go	0.00% <0.00%> (ø)
api/v1alpha1/lvmcluster_webhook.go	77.50% <64.70%> (-0.81%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[qJkee]

/hold

[openshift-ci]

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-hypershift	cc0361b	link	true	/test e2e-aws-hypershift
ci/prow/precommit-check	cc0361b	link	true	/test precommit-check
ci/prow/snyk-deps	cc0361b	link	false	/test snyk-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.