Skip to content

Conversation

@tmds
Copy link
Contributor

@tmds tmds commented Oct 9, 2025

Since .NET 6 EOL, the image stream definitions are the same across available architectures. The architecture specific ImageStream definition files are removed in redhat-developer/s2i-dotnetcore#518.

@fbm3307 ptal

cc @omajid

…magestream files.

Since .NET 6 EOL, the image stream definitions are the same across available architectures.
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

Hi @tmds. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fbm3307
Copy link
Contributor

fbm3307 commented Oct 9, 2025

@aroyoredhat FYI

@aroyoredhat
Copy link

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@tmds: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aroyoredhat
Copy link

/lgtm

@aroyoredhat
Copy link

@fbm3307 I am not part of the OWNERS of this repo so you need to do the lgtm and approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
Copy link

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmds
Copy link
Contributor Author

tmds commented Oct 15, 2025

@fbm3307 can you merge this?

1 similar comment
@tmds
Copy link
Contributor Author

tmds commented Oct 21, 2025

@fbm3307 can you merge this?

@aroyoredhat
Copy link

@dperaza4dustbit It seems @fbm3307 is Out of Office, can you approve this in the meantime?

@fbm3307
Copy link
Contributor

fbm3307 commented Oct 23, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aroyoredhat, fbm3307, omajid, tmds

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c2aa83e into openshift:master Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants