OCPEDGE-1707: Add Disable Certificate Verification API #9640
Conversation
Signed-off-by: Michael Shitrit <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@mshitrit: This pull request references OCPEDGE-1707 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
jira/valid-reference
|
/test gofmt golint govet |
|
/retest |
mshitrit
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test e2e-metal-ovn-two-node-arbiter |
|
/retest |
| Username string `json:"username" validate:"required"` | ||
| Password string `json:"password" validate:"required"` | ||
| Address string `json:"address" validate:"required,uniqueField"` | ||
| DisableCertificateVerification bool `json:"disableCertificateVerification"` |
There was a problem hiding this comment.
I generally try to follow API team's guiedlines of never using booleans, instead opting for enums like Enabled Disabled. So take that if it's useful, but I'm fine with this.
There was a problem hiding this comment.
Thanks, good feedback, I'll keep that in mind for future changes.
In this particular case I was just trying to stay aligned with the BMC implementation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-metal-ovn-two-node-arbiter |
|
@mshitrit: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Before we merge this, I would like us to update the corresponding entry in openshift-metal3/dev-scripts@98fa8a1 to avoid having to do a follow up fix. |
Adding an API to disable SSL certification, one use case for this being relevant is a customer setting up redfish fencing on their internal network.