OCPBUGS-54487: Power VS: Provide detailed error when entered VPCName cannot be found #9634
Conversation
openshift-ci-robot
added
jira/severity-low
|
@AshwinHIBM: This pull request references Jira Issue OCPBUGS-54487, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@AshwinHIBM: This pull request references Jira Issue OCPBUGS-54487, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juliemathew. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
I think the changes are very helpful!
I am not familiar with the powervs code path, but I would expect there must be a validation for this vpcName field, no? It does not seem to get hit according to the description of the jira bug ticket.
Thanks! The error message does get shown, however, it's just not descriptive enough to be actionable. Hence this change. |
AshwinHIBM
force-pushed
the
vpc-missing-error
branch
from
4d5526d to
4e3304f
Compare
|
@AshwinHIBM: This pull request references Jira Issue OCPBUGS-54487, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juliemathew. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-powervs-capi-ovn |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tthvo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@AshwinHIBM: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The failure in e2e-powervs-capi-ovn does not seem related to this PR. Let's allow others to have a look and tag lgtm 😄 |
|
/assign mjturek |
When a non-existing VPC name is provided in
platform.powervs.vpcNamein the install-config, the error messaged displayed is too short and non-actionable. This PR provides a detailed error message mentioning the selected VPC and the available VPCs.