OCPBUGS-48089: validate hostPrefix to be the same when multiple clusternetwork CIDRs are present

[tthvo]

Description

When multiple clusternetwork CIDRs are present, hostPrefix fields must be specified with the same value. If not, it can impact traffic between pods in different subnets.

The patch applies validation for IPv4 CIDR. For IPv6, the only option for hostPrefix is 64, thus naturally satisfying the requirement.

Other related changes:

• Only validate for negative host prefix when the prefix is actually used.
• Added a test case for negative host prefix.

References

• https://issues.redhat.com/browse/OCPBUGS-46514 (debug steps and explanation for root cause)
• https://access.redhat.com/solutions/7100460 (temporary solution for existing cluster)

[openshift-ci-robot]

@tthvo: This pull request references Jira Issue OCPBUGS-48089, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

When multiple clusternetwork CIDRs are present, hostPrefix fields must be specified with the same value. If not, it can impact traffic between pods in different subnets.

The patch applies validation for IPv4 CIDR. For IPv6, the only option for hostPrefix is 64, thus naturally satisfying the requirement.

Other related changes:

• Only validate for negative host prefix when the prefix is actually used.
• Added a test case for negative host prefix.

References

• https://issues.redhat.com/browse/OCPBUGS-46514 (debug steps and explanation for root cause)
• https://access.redhat.com/solutions/7100460 (temporary solution for existing cluster)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/cc @patrickdillon @cpassare

[openshift-ci]

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	8c9b001	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-static-ovn	8c9b001	link	false	/test e2e-vsphere-static-ovn
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade	8c9b001	link	false	/test e2e-vsphere-host-groups-ovn-custom-no-upgrade
ci/prow/e2e-vsphere-ovn-multi-network	8c9b001	link	false	/test e2e-vsphere-ovn-multi-network

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

/approve

This LGTM but will give @cpassare a chance to take a pass

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment