Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.3] Bug 1784629: baremetal: Enable the baremetal platform to override the default rhcos images #2835

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2757

/assign stbenjam

…w config to override rhcos image for bootstrap node Add validation and unit tests for OS Image overload
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.3] baremetal: Enable the baremetal platform to override the default rhcos images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2019
@stbenjam
Copy link
Member

/retitle [release-4.3] Bug 1784629: baremetal: Enable the baremetal platform to override the default rhcos images

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] baremetal: Enable the baremetal platform to override the default rhcos images [release-4.3] Bug 1784629: baremetal: Enable the baremetal platform to override the default rhcos images Dec 17, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1784629, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.3] Bug 1784629: baremetal: Enable the baremetal platform to override the default rhcos images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 17, 2019
@hardys
Copy link

hardys commented Dec 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@stbenjam
Copy link
Member

/assign wking

@sdodson
Copy link
Member

sdodson commented Dec 18, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit e0dde18 into openshift:release-4.3 Dec 18, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1784629 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1784629: baremetal: Enable the baremetal platform to override the default rhcos images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys pushed a commit to hardys/dev-scripts that referenced this pull request Dec 18, 2019
Since openshift/installer#2757
merged we can mirror the installer referenced images directly
to simulate typical disconnected install scenarios.

This removes some complexity as we no longer need to run the
downloader container on the host, only expose the unprocessed images
via http.

Note this will work with latest 4.4. builds but not 4.3 until
openshift/installer#2835 lands
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Dec 18, 2019
Since openshift/installer#2757
merged we can mirror the installer referenced images directly
to simulate typical disconnected install scenarios.

This removes some complexity as we no longer need to run the
downloader container on the host, only expose the unprocessed images
via http.

Note this will work with latest 4.4. builds but not 4.3 until
openshift/installer#2835 lands
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Dec 19, 2019
Since openshift/installer#2757
merged we can mirror the installer referenced images directly
to simulate typical disconnected install scenarios.

This removes some complexity as we no longer need to run the
downloader container on the host, only expose the unprocessed images
via http.

Note this will work with latest 4.4. builds but not 4.3 until
openshift/installer#2835 lands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants