OCPBUGS-63065: Expand Azure userTags to support Azure Government Cloud #10015
Conversation
|
/test e2e-azure-ovn-shared-vpc |
1 similar comment
|
/test e2e-azure-ovn-shared-vpc |
patrickdillon
changed the title
openshift-ci-robot
added
the
jira/severity-low
|
/jira refresh |
openshift-ci-robot
added
jira/valid-reference
|
@fahlmant: This pull request references Jira Issue OCPBUGS-63065, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@patrickdillon: This pull request references Jira Issue OCPBUGS-63065, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fahlmant don't worry too much about those failing tests. we are having some azure ci quota issues. |
|
/approve Let's wait for @gpei to verify |
openshift-ci
bot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon, shubhadapaithankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@gpei: This pull request references Jira Issue OCPBUGS-63065, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gpei Is there anything you need from me to help move this forward? |
|
Hi @fahlmant , the test on the PR have been completed by @jinyunma and can be found here https://issues.redhat.com/browse/OCPBUGS-63065?focusedId=28262169&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28262169. We are currently awaiting Patrick's evaluation of the remaining issue. |
|
@patrickdillon Could I get your thoughts on this? |
|
/verified by @patrickdillon Jinyun did the work, but marking this as verified by me because we are deferring some of the work to an existing bug OCPBUGS-36207 |
openshift-ci-robot
added
the
verified
|
@patrickdillon: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fahlmant: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold Revision 15ad237 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
5 participants
Azure US Government Cloud has no restrictions on using resource tags. Recently, ARO tried to add userTags support to the install process but when deploying to the Government Cloud regions, clusters were unable to be created due to the limitation in the installer. Given that these Azure regions support tags, this PR allows user tags to be used in both Azure Public and US Government Clouds.