Skip to content

Commit

Permalink
Fix Azure cloud provider subnet reference
Browse files Browse the repository at this point in the history
On Azure, the installer is configuring the cloud provider with a subnet using a
`-node-subnet` suffix. This is incorrect, as the actual subnet created for Azure
has a `-worker-subnet` suffix. The cloud provider refers to this subnet when
creating internal load balancers. Because of the invalid subnet reference,
kube-controller-manager fails to find the subnet, and thus fails to provision
internal load balancers. This commit fixes the reference and thus fixes internal
ingresscontrollers on Azure for new installations.

This commit does not fix existing invalid cloudprovider configmaps.

This is a fix of https://bugzilla.redhat.com/show_bug.cgi?id=1763727 only for
new installations.
  • Loading branch information
ironcladlou committed Oct 23, 2019
1 parent 1c32be0 commit cfa5d59
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/asset/manifests/cloudproviderconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func (cpc *CloudProviderConfig) Generate(dependencies asset.Parents) error {
if installConfig.Config.Azure.VirtualNetwork != "" {
vnet = installConfig.Config.Azure.VirtualNetwork
}
subnet := fmt.Sprintf("%s-node-subnet", clusterID.InfraID)
subnet := fmt.Sprintf("%s-worker-subnet", clusterID.InfraID)
if installConfig.Config.Azure.ComputeSubnet != "" {
subnet = installConfig.Config.Azure.ComputeSubnet
}
Expand Down

0 comments on commit cfa5d59

Please sign in to comment.