fix: add velero to renovate ignoreDeps by kaovilai · Pull Request #225 · openshift/hypershift-oadp-plugin

kaovilai · 2026-03-26T17:53:22Z

Summary

Add github.com/vmware-tanzu/velero and github.com/openshift/velero to ignoreDeps in renovate.json
Prevents Renovate/MintMaker from creating PRs that update velero to incompatible versions
The openshift/velero fork is managed via replace directive and must track specific oadp-* branches manually

Closes #223

Context

Renovate PRs #215 and #216 updated velero to v1.2.0 which removed the v2alpha1 API package that the plugin depends on. The velero dependency should be managed manually to track the correct openshift/velero branch.

Note

Responses generated with Claude

The openshift/velero fork is managed via a go.mod replace directive and must track specific oadp-* branches. Renovate incorrectly updates it to incompatible versions (e.g. v1.2.0) that remove APIs the plugin depends on (velero/pkg/apis/velero/v2alpha1). Closes openshift#223 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

coderabbitai · 2026-03-26T17:53:45Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ae8684f-ccdc-4b03-b3a7-0f067c59222f

📥 Commits

Reviewing files that changed from the base of the PR and between d62f95e and 9144fbb.

📒 Files selected for processing (1)

renovate.json

Walkthrough

The PR adds an ignoreDeps configuration to renovate.json, instructing Renovate to skip automatic updates for github.com/vmware-tanzu/velero and github.com/openshift/velero dependencies.

Changes

Cohort / File(s)	Summary
Renovate Configuration `renovate.json`	Added `ignoreDeps` array with two Velero dependencies to prevent Renovate from automatically updating these packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Update `go.mod` replace directive to track `oadp-1.6` branch instead of stale `oadp-1.5` pseudo-version [`#223`]	❌	The replace directive in `go.mod` was not modified. The PR only configures Renovate to ignore these dependencies.
Ensure Renovate/MintMaker configuration handles Velero dependency updates appropriately [`#223`]	❓	The `ignoreDeps` configuration prevents Renovate from updating Velero, but does not configure it to understand or maintain the replace directive. This avoids the immediate problem but doesn't align with the proposed fix of updating the replace directive and ensuring ongoing updates via Renovate.

Out-of-scope changes

Code Change	Explanation
Added `ignoreDeps` configuration for Velero dependencies (renovate.json)	While this prevents Renovate-related failures, it sidesteps the core objective of `#223`, which requires updating the `go.mod` replace directive to `oadp-1.6` and ensuring Renovate works with an updated replace mechanism. Ignoring the dependencies entirely bypasses rather than resolves the dependency management issue.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Updates Renovate configuration to stop automated dependency PRs from bumping Velero modules to incompatible versions, aligning with the repo’s need to manage the upstream/forked Velero version manually.

Changes:

Added github.com/vmware-tanzu/velero to Renovate ignoreDeps.
Added github.com/openshift/velero to Renovate ignoreDeps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

openshift-ci · 2026-03-26T17:56:36Z

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jparrill

/lgtm

jparrill · 2026-03-27T08:18:04Z

/retest

kaovilai · 2026-03-27T14:29:50Z

/override oadp-hypershift-oadp-plugin-main-on-pull-request

kaovilai · 2026-03-27T14:29:54Z

/override oadp-hypershift-oadp-plugin-main-on-pull-request

openshift-ci · 2026-03-27T14:31:15Z

@kaovilai: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

[oadp-hypershift-oadp-plugin-main-on-pull-request](https://github.com/openshift/hypershift-oadp-plugin/pull/225/checks?check_run_id=68849587996)

Only the following failed contexts/checkruns were expected:

Cleanup artifacts
CodeRabbit
Red Hat Konflux / oadp-hypershift-oadp-plugin-main-on-pull-request
Red Hat Konflux / oadp-hypershift-velero-plugin-enterprise-contract / oadp-hypershift-oadp-plugin-main
ci/prow/build
ci/prow/security
ci/prow/unit
ci/prow/verify
pull-ci-openshift-hypershift-oadp-plugin-main-build
pull-ci-openshift-hypershift-oadp-plugin-main-security
pull-ci-openshift-hypershift-oadp-plugin-main-unit
pull-ci-openshift-hypershift-oadp-plugin-main-verify
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override oadp-hypershift-oadp-plugin-main-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-03-27T14:31:16Z

@kaovilai: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

oadp-hypershift-oadp-plugin-main-on-pull-request

Only the following failed contexts/checkruns were expected:

Cleanup artifacts
CodeRabbit
Red Hat Konflux / oadp-hypershift-oadp-plugin-main-on-pull-request
Red Hat Konflux / oadp-hypershift-velero-plugin-enterprise-contract / oadp-hypershift-oadp-plugin-main
ci/prow/build
ci/prow/security
ci/prow/unit
ci/prow/verify
pull-ci-openshift-hypershift-oadp-plugin-main-build
pull-ci-openshift-hypershift-oadp-plugin-main-security
pull-ci-openshift-hypershift-oadp-plugin-main-unit
pull-ci-openshift-hypershift-oadp-plugin-main-verify
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override oadp-hypershift-oadp-plugin-main-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kaovilai · 2026-03-28T20:08:55Z

/override "Red Hat Konflux / oadp-hypershift-oadp-plugin-main-on-pull-request"

openshift-ci · 2026-03-28T20:09:09Z

@kaovilai: Overrode contexts on behalf of kaovilai: Red Hat Konflux / oadp-hypershift-oadp-plugin-main-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / oadp-hypershift-oadp-plugin-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mpryc · 2026-03-31T16:12:11Z

/lgtm

openshift-ci · 2026-03-31T19:15:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI review requested due to automatic review settings March 26, 2026 17:53

openshift-ci bot requested review from csrwng and muraee March 26, 2026 17:53

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026

Copilot started reviewing on behalf of kaovilai March 26, 2026 17:53 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

jparrill reviewed Mar 27, 2026

View reviewed changes

openshift-ci bot assigned jparrill Mar 27, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026

openshift-ci bot assigned mpryc Mar 31, 2026

sseago approved these changes Mar 31, 2026

View reviewed changes

openshift-ci bot assigned sseago Mar 31, 2026

Conversation

kaovilai commented Mar 26, 2026

Summary

Context

Uh oh!

coderabbitai bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Assessment against linked issues

Out-of-scope changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

openshift-ci bot commented Mar 26, 2026

Uh oh!

jparrill left a comment

Choose a reason for hiding this comment

Uh oh!

jparrill commented Mar 27, 2026

Uh oh!

kaovilai commented Mar 27, 2026

Uh oh!

kaovilai commented Mar 27, 2026

Uh oh!

openshift-ci bot commented Mar 27, 2026

Uh oh!

openshift-ci bot commented Mar 27, 2026

Uh oh!

kaovilai commented Mar 28, 2026

Uh oh!

openshift-ci bot commented Mar 28, 2026

Uh oh!

mpryc commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Mar 26, 2026 •

edited

Loading