fix(deps): update non-k8s-go-dependencies#209
fix(deps): update non-k8s-go-dependencies#209red-hat-konflux[bot] wants to merge 1 commit intomainfrom
Conversation
red-hat-konflux
bot
added
area/ci-tooling
ok-to-test
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 6-11: Update code and operators to accommodate the dependency
upgrades in go.mod: remove any separate CSI plugin installation/config code and
rely on the merged CSI behavior from github.com/vmware-tanzu/velero v1.18.0;
remove or guard any logic that installs or relies on restic fs-backup, and
ensure existing restic restore paths are still supported until v1.19; review and
adjust any namespace filtering logic that reads
includedNamespaces/excludedNamespaces and labelSelector to match Velero's new
semantics (search for references to includedNamespaces/excludedNamespaces and
labelSelector in backup/restore code); change repository maintenance
configuration from server flag parsing to reading the Velero maintenance
ConfigMap name/keys where maintenance jobs are configured; audit restore
handling for PersistentVolumes that may be Finalizing and update error/status
handling to accept PartiallyFailed states; and for snapshot code that imports
github.com/kubernetes-csi/external-snapshotter/client/v8, plan/migrate APIs from
VolumeGroupSnapshot v1beta1 to the new v1beta2 and avoid writing to fields that
are now immutable (search for VolumeGroupSnapshot types/usages to update).
6c55abc to
eaece54
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 80: Update and verify gRPC compatibility: ensure the project Go version
is bumped to at least 1.24 in go.mod and CI configs, then scan the codebase for
any custom types or implementations named Reader and MetricsRecorder (search for
type Reader, struct/interface declarations and any types implementing
MetricsRecorder); if Reader is implemented as an interface, migrate it to the
new struct-based usage or adapt call sites, and for any MetricsRecorder
implementations embed or compose UnimplementedMetricsRecorder into your
MetricsRecorder types so they satisfy the new API; also ensure you are not
targeting retracted v1.74.x versions and adjust the go.mod entry for
google.golang.org/grpc to a supported 1.76+ or 1.79.2 after these changes.
- Around line 50-52: The go-openapi updates (notably github.com/go-openapi/swag
v0.25.5 and github.com/go-openapi/jsonpointer v0.22.5) require action: confirm
the project Go toolchain is updated to Go 1.24 or pin swag to a
pre-1.24-compatible version; if you keep swag v0.25.5 register the easyjson
adapter at runtime or switch to the stdlib adapter if your code relied on
mailru/easyjson; add any now-removed transitive dependencies (e.g.,
mailru/easyjson, github.com/josharian/intern) explicitly to go.mod if your code
used them; and update imports that referenced deprecated root APIs from
github.com/go-openapi/swag to the new submodules (conv, jsonutils, yamlutils or
swag/jsonname) across the codebase (search for imports of
github.com/go-openapi/swag and github.com/go-openapi/jsonpointer/jsonname) and
adjust call sites to the modernized APIs.
eaece54 to
dc8b12f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 11: The go.mod currently declares github.com/vmware-tanzu/velero v1.14.0
but the replace directive redirects to an OpenShift fork at v0.10.2..., causing
an unsupported upgrade mismatch; update the replace directive or the declared
Velero version so both refer to compatible majors: either point the replace to
an openshift/velero fork that is v1.14.0-compatible (or upstream v1.14.0) or
downgrade the module declaration from v1.14.0 to the v0.10.x series and follow
Velero’s documented incremental upgrade path; edit the go.mod replace line and
the module version declaration consistently so the visited versions (declared
version and replaced target) share a supported upgrade path.
dc8b12f to
4639995
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
go.mod (1)
11-11:⚠️ Potential issue | 🟠 MajorPotential Velero compatibility skew between
requireandreplace.Line 11 requires
github.com/vmware-tanzu/velero v1.18.0, but Line 93 replaces it with an OpenShift fork pseudo-version based onv0.10.2. That major skew can introduce API/runtime incompatibilities and makes upgrade intent ambiguous.#!/bin/bash set -euo pipefail echo "=== Velero require/replace in go.mod ===" rg -n 'github.com/vmware-tanzu/velero|replace github.com/vmware-tanzu/velero' go.mod echo echo "=== Compare replaced OpenShift fork commit against upstream Velero v1.18.0 ===" FORK_SHA="8fbcf3a8da11" gh api repos/openshift/velero/compare/v1.18.0...${FORK_SHA} --jq '{status, ahead_by, behind_by, total_commits}'Expected: if this replace is intended for v1.18 compatibility, comparison should show a clearly documented alignment strategy; otherwise pin to a fork/version line that matches the required major.
As per coding guidelines, "**: -Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."Also applies to: 93-93
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 11, The go.mod shows a mismatch: require github.com/vmware-tanzu/velero v1.18.0 but a replace maps github.com/vmware-tanzu/velero to an OpenShift fork pseudo-version based on v0.10.2, which can cause API/runtime incompatibilities; update go.mod so the replace target aligns with the required major version or change the require to the forked version and clearly document the reason. Locate the require line for github.com/vmware-tanzu/velero and the replace directive in go.mod, then either (a) adjust the replace target to an OpenShift commit/tag that is explicitly compatible with v1.18.0 and add a short comment documenting the compatibility/commit, or (b) change the require to the forked version (or remove the replace) so major versions match, and add a comment explaining the intentional fork and upgrade strategy.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 8: Replace raw commit-hash references in the go.mod require blocks with
canonical pseudo-versions (or tagged releases); specifically update entries like
"github.com/openshift/hive/apis 366515c6aedd" (and the other hash-only entries
mentioned) to their pseudo-version form (e.g.,
v0.0.0-YYYYMMDDHHMMSS-366515c6aedd) by running go get -u
github.com/openshift/hive/apis@366515c6aedd (and similarly for the other
modules) or switching to an available semver tag, then tidy modules with go mod
tidy to persist the changes.
---
Duplicate comments:
In `@go.mod`:
- Line 11: The go.mod shows a mismatch: require github.com/vmware-tanzu/velero
v1.18.0 but a replace maps github.com/vmware-tanzu/velero to an OpenShift fork
pseudo-version based on v0.10.2, which can cause API/runtime incompatibilities;
update go.mod so the replace target aligns with the required major version or
change the require to the forked version and clearly document the reason. Locate
the require line for github.com/vmware-tanzu/velero and the replace directive in
go.mod, then either (a) adjust the replace target to an OpenShift commit/tag
that is explicitly compatible with v1.18.0 and add a short comment documenting
the compatibility/commit, or (b) change the require to the forked version (or
remove the replace) so major versions match, and add a comment explaining the
intentional fork and upgrade strategy.
2f7f833 to
d4c14bc
Compare
openshift-ci
bot
removed
the
needs-rebase
red-hat-konflux
bot
force-pushed
the
konflux/mintmaker/main/non-k8s-go-dependencies
branch
26 times, most recently
from
3f05fc2 to
73df7fd
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
bot
force-pushed
the
konflux/mintmaker/main/non-k8s-go-dependencies
branch
from
73df7fd to
88da7e7
Compare
|
@red-hat-konflux[bot]: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v3.12.2->v3.13.0v1.18.0->v1.19.0v2.9.0->v2.9.1v0.21.1->v0.22.5v0.21.0->v0.21.5v0.23.1->v0.25.5v0.7.0->v0.7.1v0.14.1->v0.16.2v1.6.0->v1.7.0v0.1.1->v0.1.2v0.9.0->v0.9.2v1.0.0->v1.14.1v1.0.0->v1.2.04c643a6->2757d673f49f26->aec89c68eaac17->5ed3475v0.16.1->v0.20.1v1.14.0->v1.18.01.25.8->1.26.1v2.4.3->v2.4.4v0.35.0->v0.36.0v0.14.0->v0.15.0f26f940->9d38bb4v1.77.0->v1.80.0Release Notes
emicklei/go-restful (github.com/emicklei/go-restful/v3)
v3.13.0Compare Source
fatih/color (github.com/fatih/color)
v1.19.0Compare Source
What's Changed
Fprint,Fprintfby @qualidafial in #282New Contributors
Full Changelog: fatih/color@v1.18.0...v1.19.0
fxamacker/cbor (github.com/fxamacker/cbor/v2)
v2.9.1Compare Source
This release includes important bugfixes, defensive checks, improved code quality, and more tests. Although not public, the fuzzer was also improved by adding more fuzz tests.
🐞 Bug fixes related to the
keyasintfeatureThese changes only affect Go struct fields tagged with
keyasint:math.MaxInt64when decoding CBOR map to a struct withkeyasintfield (PR #757)keyasinttag values (PR #757)🐞 Other bug fixes and defensive checks
Some of the bugs fixed are related to decoding extreme values that cannot be encoded with this library. For example, the decoder checks if epoch time encoded as CBOR float value representing hundreds of billions of years overflows int64(seconds).
NOTE: It is generally good practice to avoid using floating point to store epoch time (even when not using CBOR).
RawMessagefromRawMessage.MarshalCBOR(PR #753)U+FFFDreplacement character (PR #753)What's Changed
TimeRFC3339NanoUTCby @fxamacker in #688CI / GitHub Actions and Docs
🔎 Details...
New Contributors
Full Changelog: fxamacker/cbor@v2.9.0...v2.9.1
go-openapi/jsonpointer (github.com/go-openapi/jsonpointer)
v0.22.5Compare Source
0.22.5 - 2026-03-02
Full Changelog: go-openapi/jsonpointer@v0.22.4...v0.22.5
15 commits in this release.
Documentation
Code quality
Miscellaneous tasks
Updates
People who contributed to this release
New Contributors
in #97
jsonpointer license terms
v0.22.4Compare Source
0.22.4 - 2025-12-06
Full Changelog: go-openapi/jsonpointer@v0.22.3...v0.22.4
1 commits in this release.
Miscellaneous tasks
People who contributed to this release
jsonpointer license terms
v0.22.3Compare Source
0.22.3 - 2025-11-17
Full Changelog: go-openapi/jsonpointer@v0.22.2...v0.22.3
8 commits in this release.
Documentation
Code quality
Miscellaneous tasks
People who contributed to this release
New Contributors
in #76
jsonpointer license terms
v0.22.2Compare Source
0.22.2 - 2025-11-14
Full Changelog: go-openapi/jsonpointer@v0.22.1...v0.22.2
12 commits in this release.
Documentation
Code quality
Testing
Miscellaneous tasks
Security
Updates
People who contributed to this release
jsonpointer license terms
v0.22.1Compare Source
v0.22.0Compare Source
v0.21.2Compare Source
go-openapi/jsonreference (github.com/go-openapi/jsonreference)
v0.21.5Compare Source
0.21.5 - 2026-03-02
Full Changelog: go-openapi/jsonreference@v0.21.4...v0.21.5
14 commits in this release.
Documentation
Code quality
Testing
Miscellaneous tasks
Updates
People who contributed to this release
jsonreference license terms
v0.21.4Compare Source
0.21.4 - 2025-12-08
Full Changelog: go-openapi/jsonreference@v0.21.3...v0.21.4
1 commits in this release.
Documentation
People who contributed to this release
New Contributors
in #64
jsonreference license terms
v0.21.3Compare Source
v0.21.2Compare Source
v0.21.1Compare Source
go-openapi/swag (github.com/go-openapi/swag)
v0.25.5Compare Source
0.25.5 - 2026-03-02
Full Changelog: go-openapi/swag@v0.25.4...v0.25.5
16 commits in this release.
Documentation
Code quality
Testing
Miscellaneous tasks
Updates
People who contributed to this release
New Contributors
swag license terms
Per-module changes
cmdutils (0.25.5)
Testing
conv (0.25.5)
Testing
Miscellaneous tasks
Updates
fileutils (0.25.5)
Testing
Updates
jsonname (0.25.5)
Testing
Updates
jsonutils/adapters/easyjson (0.25.5)
Testing
Miscellaneous tasks
Updates
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.