-
Notifications
You must be signed in to change notification settings - Fork 16
ESO-275: Updates bundle name to distinguish from the upstream helm installations #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bharath-b-rh: This pull request references ESO-275 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "eso-1.1" instead. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
WalkthroughRenamed operator from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bharath-b-rh: This pull request references ESO-275 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "eso-1.1" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@bundle/manifests/openshift-external-secrets-operator.clusterserviceversion.yaml`:
- Line 845: The CSV's replaces field currently points to a CSV in a different
package ("external-secrets-operator.v1.0.0"); update the replaces entry to the
matching package name by changing the replaces value to
"openshift-external-secrets-operator.v1.0.0" so the CSV replaces target is in
the same package as the current CSV (modify the replaces field in the
clusterserviceversion YAML).
bundle/manifests/openshift-external-secrets-operator.clusterserviceversion.yaml
Show resolved
Hide resolved
|
/lgtm |
|
/label px-approved @emmajiafan Could you please help with verified label. Also I think openshift/external-secrets-operator-release#230 is required to verify end-to-end. Thank you! @snarayan-redhat Could you please help with docs label. We need to add details in the RN. The operator CSV name is updated from |
…stallations Signed-off-by: Bharath B <bhb@redhat.com>
|
@bharath-b-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/label qe-approved |
|
@bharath-b-rh: This pull request references ESO-275 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "eso-1.1" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label docs-approved |
The PR is for updating the operator name from
external-secrets-operatortoopenshift-external-secrets-operatorto distinguish the downstream deployments from upstream deployments.