OCPNODE-3029: user namespaces: add required minimum kubelet version #1766
Conversation
|
cc @JoelSpeed |
haircommander
changed the title
|
@haircommander: This pull request references OCPNODE-3029 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
| Then, the featuregate controller in the cluster-config-operator will be extended to filter features from the Enabled set if the minimum kubelet version isn't set old enough. | ||
| This will give openshift feature developers a mechansim to programatically declare a feature requires a certain version of the kubelet. This will be used for user namespaces, | ||
| and the corresponding version for user namespaces and related feature gates will be "1.30.0" |
There was a problem hiding this comment.
Can you describe what will happen when two feature gates declare different minimum versions?
How will the feature gate controller know what version it should allow?
There was a problem hiding this comment.
I added a blurb describing, if there are multiple versions then the feature gate controller will only filter the features that have a version higher than the defined one
haircommander
force-pushed
the
required-min-kubelet
branch
from
827964e to
acebc94
Compare
openshift-ci
bot
added
the
do-not-merge/hold
|
I can think of @deads2k having some input. Also: @JoelSpeed you're on the list of owners of https://github.com/openshift/cluster-config-operator/blob/master/OWNERS are you the person I should annoy about reviewing those updates when they're ready? if not that person should probably also have a look |
|
David or I can approve the feature gate controller update |
|
MCO rollback piece POC: openshift/machine-config-operator#4929 |
Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
required-min-kubelet
branch
from
acebc94 to
b752a16
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This feature allows a feature gate author to programatically declare the minimum kubelet version that must be set to allow this feature to be turned on.