Skip to content

CONSOLE-4581: expose swagger getPropertyDescription function #15075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamviktora
Copy link

Exposes a getSwaggerPropertyDescription function, so it can be consumed by dynamic plugins from console-dynamic-plugin-sdk.

This function is used to get a popover body content for a given property of a given K8sModel, e.g. "metadata.labels" of a IoK8sApiCoreV1Service:

Screenshot 2025-05-21 at 9 32 43

Plugins will use this if they need to overwrite the standard "resource details" page in order to extend it.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 21, 2025

@adamviktora: This pull request references CONSOLE-4581 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Exposes a getSwaggerPropertyDescription function, so it can be consumed by dynamic plugins from console-dynamic-plugin-sdk.

This function is used to get a popover body content for a given property of a given K8sModel, e.g. "metadata.labels" of a IoK8sApiCoreV1Service:

Screenshot 2025-05-21 at 9 32 43

Plugins will use this if they need to overwrite the standard "resource details" page in order to extend it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2025
@openshift-ci openshift-ci bot requested review from rhamilto and vojtechszocs May 21, 2025 07:36
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/sdk Related to console-plugin-sdk plugin-api-changed Categorizes a PR as containing plugin API changes labels May 21, 2025
@adamviktora
Copy link
Author

/retest

@adamviktora adamviktora force-pushed the expose-getSwaggerPropertyDescription branch from f56a766 to 17e0c9c Compare May 21, 2025 13:24
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adamviktora
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhadvig. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adamviktora
Copy link
Author

/retest

Copy link
Contributor

openshift-ci bot commented May 21, 2025

@adamviktora: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 17e0c9c link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/sdk Related to console-plugin-sdk jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. plugin-api-changed Categorizes a PR as containing plugin API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants