Skip to content

ODC-7797: Expose PodRingSet via Dynamic Plugin SDK #15068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

ODC-7797: Expose PodRingSet via Dynamic Plugin SDK #15068

merged 1 commit into from
May 26, 2025

Conversation

lokanandaprabhu
Copy link
Contributor

Story:

https://issues.redhat.com/browse/ODC-7797

Description:

Exposed PodRingSet to dynamic plugins via internal topology packlage

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 19, 2025 •
edited by openshift-ci bot
Loading

@lokanandaprabhu: This pull request references ODC-7797 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7797

Description:

Exposed PodRingSet to dynamic plugins via internal topology packlage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2025
@openshift-ci openshift-ci bot requested review from spadgett and vojtechszocs May 19, 2025 06:49
@openshift-ci openshift-ci bot added component/sdk Related to console-plugin-sdk component/shared Related to console-shared plugin-api-changed Categorizes a PR as containing plugin API changes labels May 19, 2025
@lokanandaprabhu
Copy link
Contributor Author

/cc @sanketpathak @vikram-raj

@openshift-ci openshift-ci bot requested review from sanketpathak and vikram-raj May 19, 2025 06:49
@lokanandaprabhu
Copy link
Contributor Author

/retest

@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2025
@lokanandaprabhu
Copy link
Contributor Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels May 20, 2025
@lokanandaprabhu
Copy link
Contributor Author

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@lokanandaprabhu: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vojtechszocs
Copy link
Contributor

/label plugin-api-approved

@openshift-ci openshift-ci bot added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label May 20, 2025
@sanketpathak
Copy link
Contributor

Verified on a cluster for pod rings
Screenshot From 2025-05-21 18-13-52
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 21, 2025 •
edited by openshift-ci bot
Loading

@lokanandaprabhu: This pull request references ODC-7797 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7797

Description:

Exposed PodRingSet to dynamic plugins via internal topology packlage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1b1c0b8 and 2 for PR HEAD 8c6caef in total

@lokanandaprabhu
Copy link
Contributor Author

/retest

2 similar comments
@lokanandaprabhu
Copy link
Contributor Author

/retest

@lokanandaprabhu
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1b1c0b8 and 2 for PR HEAD 8c6caef in total

@lokanandaprabhu
Copy link
Contributor Author

/retest

1 similar comment
@lokanandaprabhu
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 26, 2025

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 36cb049 into openshift:main May 26, 2025
7 checks passed
@openshift-cherrypick-robot
Copy link

@lokanandaprabhu: new pull request created: #15086

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett Awaiting requested review from spadgett

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

Assignees

@vojtechszocs vojtechszocs

@spadgett spadgett

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer plugin-api-changed Categorizes a PR as containing plugin API changes px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lokanandaprabhu @openshift-ci-robot @vojtechszocs @openshift-cherrypick-robot @sanketpathak @spadgett @jhadvig