Skip to content

OCPBUGS-56179: Add isAllNamespacesKey function to dynamic plugin API #15066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vojtechszocs
Copy link
Contributor

This adds new isAllNamespacesKey utility function so that plugins don't have to hardcode #ALL_NS# value.

@vojtechszocs vojtechszocs changed the title Add isAllNamespacesKey function to dynamic plugin API OCPBUGS-56179: Add isAllNamespacesKey function to dynamic plugin API May 16, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 16, 2025
@openshift-ci-robot
Copy link
Contributor

@vojtechszocs: This pull request references Jira Issue OCPBUGS-56179, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This adds new isAllNamespacesKey utility function so that plugins don't have to hardcode #ALL_NS# value.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kyoto and spadgett May 16, 2025 16:23
@openshift-ci openshift-ci bot added component/sdk Related to console-plugin-sdk component/shared Related to console-shared plugin-api-changed Categorizes a PR as containing plugin API changes approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2025
@vojtechszocs
Copy link
Contributor Author

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label plugin-api-approved

@openshift-ci openshift-ci bot added plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer lgtm Indicates that a PR is ready to be merged. labels May 19, 2025
Copy link
Contributor

openshift-ci bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto
Copy link
Member

kyoto commented May 20, 2025

/retest

Copy link
Contributor

openshift-ci bot commented May 20, 2025

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk component/shared Related to console-shared jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer plugin-api-changed Categorizes a PR as containing plugin API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants