Skip to content

CONSOLE-4575: Refactor CommonActionFactory to hook form. #15063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CONSOLE-4575: Refactor CommonActionFactory to hook form. #15063

wants to merge 1 commit into from
+253 −226

Conversation

Mylanos
Copy link
Contributor

@Mylanos Mylanos commented May 16, 2025

  • wrapped the existing factory into a useCommonActionFactory, while keeping the existing structure of Actions.
  • adjusted consumers of CommonActionFactory and getCommonResourceAction to use the new hook form.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4575 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

  • wrapped the existing factory into a useCommonActionFactory, while keeping the existing structure of Actions.
  • adjusted consumers of CommonActionFactory and getCommonResourceAction to use the new hook form.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos Mylanos changed the title CONSOLE-4575: Refactor CommonActionFactory to hook. CONSOLE-4575: Refactor CommonActionFactory to hook form. May 16, 2025
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label May 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/helm Related to helm-plugin component/knative Related to knative-plugin component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 16, 2025
@Mylanos
Copy link
Contributor Author

Mylanos commented May 19, 2025

/retest

@Mylanos Mylanos force-pushed the CommonActionFactory-refactor branch from c8a47c5 to 258cc4d Compare May 22, 2025 10:17
@Mylanos
CONSOLE-4575: Refactor CommonActionFactory and getCommonResourceActio…
1c748c5 
…ns to hook form.

	- wrap the existing factory into a useCommonActionFactory, while keeping the existing structure of Actions.
	- adjust consumers of CommonActionFactory and getCommonResourceAction to use the new hook form.
@Mylanos Mylanos force-pushed the CommonActionFactory-refactor branch from 258cc4d to 1c748c5 Compare May 22, 2025 11:30
@Mylanos
Copy link
Contributor Author

Mylanos commented May 26, 2025

/retest

2 similar comments
@Mylanos
Copy link
Contributor Author

Mylanos commented May 26, 2025

/retest

@Mylanos
Copy link
Contributor Author

Mylanos commented May 27, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2025

@Mylanos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 1c748c5 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@kyoto kyoto Awaiting requested review from kyoto

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/topology Related to topology jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mylanos @openshift-ci-robot