-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-46544: Post TypeScript upgrade changes #14634
OCPBUGS-46544: Post TypeScript upgrade changes #14634
Conversation
@logonoff: This pull request references Jira Issue OCPBUGS-46544, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8c1d3d9
to
0a19239
Compare
97492cd
to
752485a
Compare
752485a
to
5e18de9
Compare
@logonoff: This pull request references Jira Issue OCPBUGS-46544, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@logonoff: This pull request references Jira Issue OCPBUGS-46544, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Looks good to me once #14620 merges 👍
5e18de9
to
339e8cd
Compare
339e8cd
to
ef87ade
Compare
/label acknowledge-critical-fixes-only |
/retest |
ef87ade
to
d0ed7f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest |
ae46c91
into
openshift:master
@logonoff: Jira Issue OCPBUGS-46544: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-46544 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console |
#14620 should be merged first
ResizeObserver
type@types/node
to 18.x to prepare for Node 22 upgradets-ignore
comments so it's easier to globally find/replace later when upgradingDispatch
import, we import fromredux
instead ofreact-redux
, see Dispatch is no longer an exported member of @types/react-redux DefinitelyTyped/DefinitelyTyped#26840 (comment)ts-ignore
s and update a few missing eslint ignorests-ignore
s also now have descriptions in the same line