Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-46544: Post TypeScript upgrade changes #14634

Merged

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Dec 17, 2024

#14620 should be merged first

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 17, 2024
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-46544, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

#14620 should be merged first

  • Remove duplicated ResizeObserver type
  • Update @types/node to 18.x to prepare for Node 22 upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/topology Related to topology labels Dec 17, 2024
@logonoff logonoff force-pushed the OCPBUGS-46544-types-node branch from 8c1d3d9 to 0a19239 Compare December 17, 2024 21:07
@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin component/shared Related to console-shared labels Dec 17, 2024
@logonoff logonoff force-pushed the OCPBUGS-46544-types-node branch 2 times, most recently from 97492cd to 752485a Compare December 18, 2024 02:32
@openshift-ci openshift-ci bot added component/dashboard Related to dashboard component/gitops Related to gitops-plugin component/knative Related to knative-plugin labels Dec 18, 2024
@logonoff logonoff force-pushed the OCPBUGS-46544-types-node branch from 752485a to 5e18de9 Compare December 18, 2024 02:52
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-46544, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

#14620 should be merged first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei December 18, 2024 15:02
@logonoff logonoff changed the title OCPBUGS-46544: Update @types/node to 18.x OCPBUGS-46544: Post TypeScript upgrade changes Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-46544, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

#14620 should be merged first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Looks good to me once #14620 merges 👍

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@logonoff logonoff force-pushed the OCPBUGS-46544-types-node branch from 5e18de9 to 339e8cd Compare December 18, 2024 16:15
@logonoff logonoff force-pushed the OCPBUGS-46544-types-node branch from 339e8cd to ef87ade Compare December 19, 2024 08:01
@logonoff
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 19, 2024
@logonoff
Copy link
Member Author

/retest

@logonoff logonoff force-pushed the OCPBUGS-46544-types-node branch from ef87ade to d0ed7f8 Compare December 19, 2024 16:24
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 195e813 and 2 for PR HEAD d0ed7f8 in total

@logonoff
Copy link
Member Author

/retest

1 similar comment
@logonoff
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 945ca3b and 2 for PR HEAD d0ed7f8 in total

@logonoff
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit ae46c91 into openshift:master Dec 20, 2024
6 of 7 checks passed
@openshift-ci-robot
Copy link
Contributor

@logonoff: Jira Issue OCPBUGS-46544: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-46544 has been moved to the MODIFIED state.

In response to this:

#14620 should be merged first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff deleted the OCPBUGS-46544-types-node branch December 20, 2024 12:32
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202412201320.p0.gae46c91.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants