Skip to content

OCPNODE-3006: Drop openshift policy to DevPreviewNoUpgrade for ClusterImagePolicy to v1 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

OCPNODE-3006: Drop openshift policy to DevPreviewNoUpgrade for ClusterImagePolicy to v1 #76

merged 1 commit into from
Jul 22, 2025

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Jul 21, 2025 •
edited
Loading

openshift/api#2384 moves clusterimagepolicy to v1 has below e2e-aws-ovn-techpreview failure. This PR drops openshift policy to DevPreviewNoUpgrade, so it will not install on TechPreviewNoUpgrade environment during the process of moving ClusterImagePolicy to v1 from v1alpha1. Will add back openshift on v1 ClusterImagePolicy #74 back to TechPreviewNoUpgrade after
openshift/api#2384
openshift/machine-config-operator#5143
openshift/origin#29973

build 4.20.0-0.nightly-2025-07-15-083124, openshift/api#2384
[core@ip-10-0-163-242 ~]$ journalctl -b -f -u release-image.service -u bootkube.service
Jul 19 00:45:53 ip-10-0-163-242 bootkube.sh[4890]: [#14624] failed to create some manifests:
Jul 19 00:45:53 ip-10-0-163-242 bootkube.sh[4890]: "0000_90_openshift-cluster-image-policy.yaml": unable to get REST mapping for "0000_90_openshift-cluster-image-policy.yaml": no matches for kind "ClusterImagePolicy" in version "config.openshift.io/v1alpha1"

@QiWang19
Drop openshift policy to DevPreviewNoUpgrade
8f0a141 
Drop openshift policy to DevPreviewNoUpgrade, so it will not install on TechPreviewNoUpgrade environment during the process moving ClusterImagePolicy to v1 from v1alpha1.
Will add openshift policy openshift#74 back after
openshift/api#2384
openshift/mco#5143

Signed-off-by: Qi Wang <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 21, 2025 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Drop openshift policy to DevPreviewNoUpgrade, so it will not install on TechPreviewNoUpgrade environment during the process moving ClusterImagePolicy to v1 from v1alpha1. Will add openshift policy #74 back to TechPreviewNoUpgrade after
openshift/api#2384
openshift/machine-config-operator#5143

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dhellmann and sdodson July 21, 2025 17:59
@QiWang19 QiWang19 changed the title OCPNODE-3006: Drop openshift policy to DevPreviewNoUpgrade OCPNODE-3006: Drop openshift policy to DevPreviewNoUpgrade for ClusterImagePolicy to v1 Jul 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 21, 2025 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Drop openshift policy to DevPreviewNoUpgrade, so it will not install on TechPreviewNoUpgrade environment during the process moving ClusterImagePolicy to v1 from v1alpha1. Will add back openshift on v1 ClusterImagePolicy #74 back to TechPreviewNoUpgrade after
openshift/api#2384
openshift/machine-config-operator#5143

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 21, 2025 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Drop openshift policy to DevPreviewNoUpgrade, so it will not install on TechPreviewNoUpgrade environment during the process moving ClusterImagePolicy to v1 from v1alpha1. Will add back openshift on v1 ClusterImagePolicy #74 back to TechPreviewNoUpgrade after
openshift/api#2384
openshift/machine-config-operator#5143
openshift/origin#29973

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Jul 21, 2025 •
edited
Loading

/testwith openshift/api/master/e2e-aws-ovn-techpreview #76 openshift/api#2384

@QiWang19 QiWang19 mentioned this pull request Jul 21, 2025
Merged
wking
wking approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2025
@QiWang19
Copy link
Member Author

/assign @jupierce

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 21, 2025 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

openshift/api#2384 moves clusterimagepolicy to v1 has below e2e-aws-ovn-techpreview failure. This PR drops openshift policy to DevPreviewNoUpgrade, so it will not install on TechPreviewNoUpgrade environment during the process of moving ClusterImagePolicy to v1 from v1alpha1. Will add back openshift on v1 ClusterImagePolicy #74 back to TechPreviewNoUpgrade after
openshift/api#2384
openshift/machine-config-operator#5143
openshift/origin#29973

build 4.20.0-0.nightly-2025-07-15-083124, openshift/api#2384
[core@ip-10-0-163-242 ~]$ journalctl -b -f -u release-image.service -u bootkube.service
Jul 19 00:45:53 ip-10-0-163-242 bootkube.sh[4890]: [#14624] failed to create some manifests:
Jul 19 00:45:53 ip-10-0-163-242 bootkube.sh[4890]: "0000_90_openshift-cluster-image-policy.yaml": unable to get REST mapping for "0000_90_openshift-cluster-image-policy.yaml": no matches for kind "ClusterImagePolicy" in version "config.openshift.io/v1alpha1"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Jul 21, 2025

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2025
@QiWang19
Copy link
Member Author

/retest-required

@jupierce
Copy link

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, QiWang19, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3cda34c and 2 for PR HEAD 8f0a141 in total

@sdodson
Copy link
Member

sdodson commented Jul 22, 2025

/override ci/prow/okd-e2e-aws ci/prow/okd-e2e-aws-upgrade ci/prow/okd-images

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/okd-e2e-aws, ci/prow/okd-e2e-aws-upgrade, ci/prow/okd-images

In response to this:

/override ci/prow/okd-e2e-aws ci/prow/okd-e2e-aws-upgrade ci/prow/okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b80bb06 into openshift:main Jul 22, 2025
10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-update-keys
This PR has been included in build ose-cluster-update-keys-container-v4.20.0-202507220613.p0.gb80bb06.assembly.stream.el9.
All builds following this will include this PR.

@QiWang19 QiWang19 mentioned this pull request Jul 23, 2025
Merged
@QiWang19 QiWang19 mentioned this pull request Aug 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@sdodson sdodson Awaiting requested review from sdodson

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@wking wking

@jupierce jupierce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@QiWang19 @openshift-ci-robot @sdodson @jupierce @openshift-bot @wking