Skip to content

Conversation

@Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Nov 5, 2025

Force specification of defaultHugePagesSize value when
hugePages are configured in the PerformanceProfile.

Signed-off-by: Talor Itzhak [email protected]

Force specifictaion of defaultHugePagesSize value when
hugePages are configured in the PerformanceProfile.

Signed-off-by: Talor Itzhak <[email protected]>
@openshift-ci openshift-ci bot requested review from ffromani and yanirq November 5, 2025 11:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tal-or
Once this PR has been reviewed and has the lgtm label, please assign jmencak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tal-or Tal-or changed the title components: validate defaultHugePagesSize OCPBUGS-64676:components: validate defaultHugePagesSize Nov 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 5, 2025
@openshift-ci-robot
Copy link
Contributor

@Tal-or: This pull request references Jira Issue OCPBUGS-64676, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Force specification of defaultHugePagesSize value when
hugePages are configured in the PerformanceProfile.

Signed-off-by: Talor Itzhak [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 5, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 5, 2025
@openshift-ci-robot
Copy link
Contributor

@Tal-or: This pull request references Jira Issue OCPBUGS-64676, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 6, 2025

/retest

For day 2 applications it will perform the validation once user
apply the PerformanceProfile

Signed-off-by: Talor Itzhak <[email protected]>
@Tal-or Tal-or force-pushed the hp_default_validation branch from 0e4e262 to 28ad1c5 Compare November 6, 2025 08:10
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 6, 2025

/retest
infra issues

@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 6, 2025

/retest

1 similar comment
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 9, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2025

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 12, 2025

/cc @MarSik

@openshift-ci openshift-ci bot requested a review from MarSik November 12, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants