Skip to content

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jul 7, 2025

golangci-lint 1.x is obsolete. Move with the times.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
@openshift-ci openshift-ci bot requested review from MarSik and Tal-or July 7, 2025 21:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@jmencak jmencak force-pushed the 4.21-golangci-lint-2.x branch from c8d9856 to f4e4a72 Compare July 8, 2025 20:46
golangci-lint 1.x is obsolete.  Move with the times.
@jmencak jmencak force-pushed the 4.21-golangci-lint-2.x branch from f4e4a72 to e728a02 Compare July 9, 2025 04:48
@jmencak jmencak changed the title WiP: Bump to golangci-lint 2.x Bump to golangci-lint 2.x Jul 9, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2025
@jmencak
Copy link
Contributor Author

jmencak commented Jul 9, 2025

/cc @mrniranjan
mostly for awareness. I wonder if you or anyone from the QE team help out with the removal of the ginkgo's deprecated reporters.ReportViaDeprecatedReporter() method in the future. This is currently the only deprecated method the linter sees.

@openshift-ci openshift-ci bot requested a review from mrniranjan July 9, 2025 05:56
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak jmencak changed the title Bump to golangci-lint 2.x NO-JIRA: Bump to golangci-lint 2.x Jul 9, 2025
@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request explicitly references no jira issue.

In response to this:

golangci-lint 1.x is obsolete. Move with the times.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2025
@jmencak
Copy link
Contributor Author

jmencak commented Jul 9, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4bee682 and 2 for PR HEAD e728a02 in total

Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4f5c8b9 into openshift:main Jul 9, 2025
18 checks passed
@jmencak jmencak deleted the 4.21-golangci-lint-2.x branch July 10, 2025 06:23
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.20.0-202507100843.p0.g4f5c8b9.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants