script: add IRQBALANCE_BANNED_CPULIST variable #1350
Conversation
|
/hold depends on cri-o/cri-o#8931 |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Tal-or The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
assets/performanceprofile/scripts/clear-irqbalance-banned-cpus.sh
Outdated
Show resolved
Hide resolved
| # CPU numbers which have their corresponding bits set to one in this mask | ||
| # will not have any irq's assigned to them on rebalance. | ||
| # so zero means all cpus are participating in load balancing. | ||
| # '-' is a special value that means all cpus are participating in load balancing. |
There was a problem hiding this comment.
The value - is an edge case of number1-number2 where both number1 and number2 are not defined. While - works, I wonder if it would make sense to try and document this in irqbalance upstream. By doing that, we'd get an official confirmation this is the intended behaviour and that it will not change in the future.
|
/retest |
new version of irqbalance start using IRQBALANCE_BANNED_CPULIST to mark the banned CPUs that are not suppose to participate in the irq balancing. We're setting the new variable with a default value `-` which means that all CPUs are participating in the irq balancing. Signed-off-by: Talor Itzhak <[email protected]>
This is only needed for cases when more control is required on the restore flow. cri-o/cri-o@e158549 In our case we do not need the restore flow at all, because the default behavior of the dynamic irqbalancing provided by cri-o is good enough for us. hence, we disable the restore flow completely. Signed-off-by: Talor Itzhak <[email protected]>
Signed-off-by: Talor Itzhak <[email protected]>
Signed-off-by: Talor Itzhak <[email protected]>
Tal-or
force-pushed
the
banned_cpus_new_var
branch
from
0eaabf7 to
d21cce5
Compare
|
@Tal-or: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/tests won't pass until we'll have cri-o/cri-o#8931 in |
A new version of irqbalance start using IRQBALANCE_BANNED_CPULIST to mark the banned CPUs
that are not suppose to participate in the irq balancing.
We're setting the new variable with a default value
-whichmeans that all CPUs are participating in the irq balancing.
Signed-off-by: Talor Itzhak [email protected]