-
Notifications
You must be signed in to change notification settings - Fork 110
OCPBUGS-55399: cluster-node-tuning-operator Pod of the hosted cluster is not listening on 60000 port which makes the target to be down #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
georgelipceanu
wants to merge
1
commit into
openshift:main
Choose a base branch
from
georgelipceanu:OCPBUGS-55399
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is welcome and seems correct, but why is it needed in the context of this PR to change the metrics server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just after retesting this without the change and it seems to work without it. When trying out fixes for this bug, I was of the belief that the NTO was blocked on this line as it would be trying to receive a response that would never come due to the switch to HTTP but it seems that it works just fine without it. Either way, I'm willing to either keep this block in this PR or open a new one with just this little piece of code. Nice catch 🙌
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the switch to HTTP, from what I've found and experimented with, I found that the NTO needed RBAC permissions to get the
ConfigMap
from the hosted cluster'skube-system
namespace while the Control-Plane-Operator in the hosted cluster, responsible for deploying the operator, did not have permission to create RBAC resources in the hosted cluster's kube-system namespace.I personally wasn't able to find a way to keep HTTPS with the current configuration but I would be willing to take a deeper dive into it HTTP won't be secure enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, IIRC, we had two issues with the metrics server reported to us by the Security team.
I'd be very reluctant to merge this without meeting both requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, in that case I'll keep looking into keeping HTTPS with the metrics server for HyperShift. However if the new
DumpCA()
code looks good then I would be willing to repurpose this PR for this code only. Is this something that the team would be interested in?