Skip to content

PSAP-1827: Add startup_udev_settle_wait option option to tunedConfig #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Jun 18, 2025

The new startup_udev_settle_wait TuneD global option has recently been added to /etc/tuned/tuned-main.conf. This option should help in situations where there are a lot of udev events during TuneD startup and TuneD is too slow to handle them.

Users may want/need to adjust this period or completely disable this functionality.

Other changes:

  • fix the logic when reapply_sysctl is undefined in /etc/tuned/tuned-main.conf

Also see: OCPBUGS-56442, OCPBUGS-57470

The new startup_udev_settle_wait TuneD global option has recently been
added to /etc/tuned/tuned-main.conf.  This option should help in
situations where there are a lot of udev events during TuneD startup and
TuneD is too slow to handle them.

Users may want/need to adjust this period or completely disable this
functionality.

Other changes:
  - fix the logic when reapply_sysctl is undefined in
    /etc/tuned/tuned-main.conf

Also see: OCPBUGS-56442, OCPBUGS-57470
@openshift-ci openshift-ci bot requested review from MarSik and rbaturov June 18, 2025 13:37
Copy link
Contributor

openshift-ci bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@jmencak
Copy link
Contributor Author

jmencak commented Jun 18, 2025

/cc @yanirq
as we talked about this briefly in the past.

@openshift-ci openshift-ci bot requested a review from yanirq June 18, 2025 13:52
@jmencak
Copy link
Contributor Author

jmencak commented Jun 18, 2025

/retest

1 similar comment
@jmencak
Copy link
Contributor Author

jmencak commented Jun 19, 2025

/retest

@jmencak jmencak changed the title Add startup_udev_settle_wait option option to tunedConfig PSAP-1827: Add startup_udev_settle_wait option option to tunedConfig Jun 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2025

@jmencak: This pull request references PSAP-1827 which is a valid jira issue.

In response to this:

The new startup_udev_settle_wait TuneD global option has recently been added to /etc/tuned/tuned-main.conf. This option should help in situations where there are a lot of udev events during TuneD startup and TuneD is too slow to handle them.

Users may want/need to adjust this period or completely disable this functionality.

Other changes:

  • fix the logic when reapply_sysctl is undefined in /etc/tuned/tuned-main.conf

Also see: OCPBUGS-56442, OCPBUGS-57470

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmencak
Copy link
Contributor Author

jmencak commented Jun 19, 2025

The errors from e2e-hypershift-pao could be genuine, this needs looking into.

@jmencak jmencak force-pushed the 4.20-udev_settle branch from 4524222 to b551c60 Compare June 20, 2025 16:37
@jmencak jmencak force-pushed the 4.20-udev_settle branch from b551c60 to 3593457 Compare June 21, 2025 19:43
Copy link
Contributor

openshift-ci bot commented Jun 21, 2025

@jmencak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 3593457 link true /test e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn 3593457 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift-pao 3593457 link true /test e2e-hypershift-pao
ci/prow/lint 3593457 link true /test lint
ci/prow/verify 3593457 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jmencak
Copy link
Contributor Author

jmencak commented Jun 29, 2025

@yanirq , after a lot of debugging, I figured out why the e2e-hypershift-pao tests are failing. The tuned API used by openshift/hypershift needs to be synchronized with the tuned API in this repository together with CRDs. Please let me know if want this PR. I'd take additional steps then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants