Skip to content

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Aug 13, 2025

Description

This PR adds the max_merged_line_bytes setting to the Vector collector configuration.
More information: kubernetes_logs/#max_merged_line_bytes

Currently, this parameter is not configurable via the Cluster Logging Forwarder spec and is hardcoded to 65536 bytes — which is twice the default value of max_line_bytes.

Using it helps prevent Vector from failing with the following error:
vector::topology: An error occurred that Vector couldn't handle: failed to encode record: BufferTooSmall.

/cc
/assign

Links

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2025
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vparfonov
Once this PR has been reviewed and has the lgtm label, please assign alanconway for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vparfonov
Copy link
Contributor Author

/hold

@vparfonov vparfonov marked this pull request as ready for review September 15, 2025 07:51
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 15, 2025
Copy link
Contributor

openshift-ci bot commented Sep 15, 2025

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant