NO-JIRA: support custom headers for Elasticsearch output

[AndrewChubatiuk]

Description

Add ability to set custom headers for Elasticsearch protocols, which are supported by Vector to allow to customize ingested logs from Openshift into VictoriaLogs

/cc @Clee2691 @cahartma
/assign @cahartma

[openshift-ci]

Hi @AndrewChubatiuk. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[vrutkovs]

/retitle NO-JIRA: support custom headers for Loki and Elasticsearch outputs
/ok-to-test

Not sure if this needs a JIRA ticket (probably it does, as there should be a release note and we'll want to backport this too)

[openshift-ci-robot]

@AndrewChubatiuk: This pull request explicitly references no jira issue.

In response to this:

Description

Add ability to set custom headers for Loki and Elasticsearch protocols, which are supported by Vector to allow to customize ingested logs from Openshift into VictoriaLogs

/cc @Clee2691 @cahartma
/assign @cahartma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vparfonov]

@AndrewChubatiuk Thanks for your contribution! Just a heads-up: according to the official docs, the Loki sink’s request block doesn’t support a headers field. https://vector.dev/docs/reference/configuration/sinks/loki/#request

[AndrewChubatiuk]

right, thanks, removed them for loki output

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrewChubatiuk
Once this PR has been reviewed and has the lgtm label, please ask for approval from cahartma. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@AndrewChubatiuk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jcantrill]

/hold

[jcantrill]

@AndrewChubatiuk if the intent is to use this to write to VictoriaLogs then is there a functional test we can provide to confirm functionallity. The larger question is what happens when RH logging to VictoriaLogs doesn't work and we are on the hook to support it with no backing tests.