Skip to content

Conversation

tchap
Copy link

@tchap tchap commented Sep 10, 2025

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2025
Copy link

coderabbitai bot commented Sep 10, 2025

Walkthrough

Adds a Go module replace directive in go.mod mapping github.com/openshift/library-go to github.com/tchap/library-go v0.0.0-20250930140150-ccd7851e777c. No other module requirements or code changes are included.

Changes

Cohort / File(s) Summary of Changes
Module resolution override
go.mod
Added replace directive: github.com/openshift/library-go => github.com/tchap/library-go v0.0.0-20250930140150-ccd7851e777c. No other require/replace edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately describes the primary change of updating the library-go dependency to bring in cert-syncer improvements and directly reflects the pull request’s core intent in a single clear sentence, making it relevant and specific to the changeset.
Description Check ✅ Passed The description succinctly notes the upstream dependency on library-go pull request #2009 and remains directly related to the changeset, ensuring it is on-topic and relevant.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0129dec and 69bca0a.

⛔ Files ignored due to path filters (11)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift/library-go/pkg/operator/certrotation/client_cert_rotation_controller.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/resource/resourceapply/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/resource/resourceread/networking.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/staticpod/certsyncpod/certsync_controller.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/staticpod/certsyncpod/hash_directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/staticpod/installerpod/cmd.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/staticpod/internal/atomicfiles/swap_directories_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/staticpod/internal/atomicfiles/swap_directories_other.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/staticpod/internal/atomicfiles/sync_directory.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • go.mod

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0bec046 and ef221da.

⛔ Files ignored due to path filters (7)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift/library-go/pkg/operator/certrotation/client_cert_rotation_controller.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/resource/resourceapply/storage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/resource/resourceread/networking.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/staticpod/certsyncpod/certsync_controller.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/staticpod/file_utils.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod (1 hunks)
🔇 Additional comments (1)
go.mod (1)

136-136: No action needed for the blank line.

@tchap tchap force-pushed the library-go-cert-syncer branch from ef221da to 97912d9 Compare September 10, 2025 13:14
@tchap
Copy link
Author

tchap commented Sep 11, 2025

/retest

@tchap
Copy link
Author

tchap commented Sep 26, 2025

/test e2e-short-cert-rotation
/test e2e-metal-ovn-sno-cert-rotation-shutdown-90d
/test e2e-metal-ovn-ha-cert-rotation-suspend-180d

@tchap
Copy link
Author

tchap commented Sep 29, 2025

/retest

1 similar comment
@tchap
Copy link
Author

tchap commented Sep 29, 2025

/retest

@tchap tchap force-pushed the library-go-cert-syncer branch from 0129dec to 69bca0a Compare September 30, 2025 14:05
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@tchap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-ha-cert-rotation-suspend-180d 0129dec link false /test e2e-metal-ovn-ha-cert-rotation-suspend-180d
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown-90d 0129dec link false /test e2e-metal-ovn-sno-cert-rotation-shutdown-90d
ci/prow/e2e-gcp-operator-single-node 69bca0a link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-ovn-serial-2of2 69bca0a link true /test e2e-aws-ovn-serial-2of2
ci/prow/okd-scos-e2e-aws-ovn 69bca0a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade 69bca0a link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node 69bca0a link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn 69bca0a link true /test e2e-aws-ovn
ci/prow/e2e-aws-operator-disruptive-single-node 69bca0a link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-serial-1of2 69bca0a link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-azure-ovn 69bca0a link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant