-
Notifications
You must be signed in to change notification settings - Fork 181
WIP: Update library-go to improve cert-syncer #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds a Go module replace directive in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tchap The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
⛔ Files ignored due to path filters (7)
go.sum
is excluded by!**/*.sum
vendor/github.com/openshift/library-go/pkg/operator/certrotation/client_cert_rotation_controller.go
is excluded by!vendor/**
,!**/vendor/**
vendor/github.com/openshift/library-go/pkg/operator/resource/resourceapply/storage.go
is excluded by!vendor/**
,!**/vendor/**
vendor/github.com/openshift/library-go/pkg/operator/resource/resourceread/networking.go
is excluded by!vendor/**
,!**/vendor/**
vendor/github.com/openshift/library-go/pkg/operator/staticpod/certsyncpod/certsync_controller.go
is excluded by!vendor/**
,!**/vendor/**
vendor/github.com/openshift/library-go/pkg/operator/staticpod/file_utils.go
is excluded by!vendor/**
,!**/vendor/**
vendor/modules.txt
is excluded by!vendor/**
,!**/vendor/**
📒 Files selected for processing (1)
go.mod
(1 hunks)
🔇 Additional comments (1)
go.mod (1)
136-136
: No action needed for the blank line.
ef221da
to
97912d9
Compare
/retest |
97912d9
to
0129dec
Compare
/test e2e-short-cert-rotation |
/retest |
1 similar comment
/retest |
0129dec
to
69bca0a
Compare
@tchap: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Depends on openshift/library-go#2009