Skip to content

API-1835: adds an integration test for the oauth-server deployment controller #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7,677 −66
Open

API-1835: adds an integration test for the oauth-server deployment controller #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions ...ion-operator/core/events/2e46-body-authentication-operator.17fe72c59b829800.b2cdb588.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
apiVersion: v1
count: 1
eventTime: null
firstTimestamp: "2024-10-14T22:38:20Z"
involvedObject:
kind: Deployment
name: authentication-operator
namespace: openshift-authentication-operator
kind: Event
lastTimestamp: "2024-10-14T22:38:20Z"
message: 'Writing updated section ("oauthServer") of observed config: "\u00a0\u00a0map[string]any(\n-\u00a0\tnil,\n+\u00a0\t{\n+\u00a0\t\t\"corsAllowedOrigins\":
[]any{string(`//127\\.0\\.0\\.1(:|$)`), string(\"//localhost(:|$)\")},\n+\u00a0\t\t\"oauthConfig\":
map[string]any{\n+\u00a0\t\t\t\"loginURL\": string(\"https://api.ostest.test.metalkube.org:6443\"),\n+\u00a0\t\t\t\"tokenConfig\":
map[string]any{\n+\u00a0\t\t\t\t\"accessTokenMaxAgeSeconds\": float64(86400),\n+\u00a0\t\t\t\t\"authorizeTokenMaxAgeSeconds\":
float64(300),\n+\u00a0\t\t\t},\n+\u00a0\t\t},\n+\u00a0\t\t\"serverArguments\": map[string]any{\n+\u00a0\t\t\t\"audit-log-format\": []any{string(\"json\")},\n+\u00a0\t\t\t\"audit-log-maxbackup\":
[]any{string(\"10\")},\n+\u00a0\t\t\t\"audit-log-maxsize\": []any{string(\"100\")},\n+\u00a0\t\t\t\"audit-log-path\": []any{string(\"/var/log/oauth-server/audit.log\")},\n+\u00a0\t\t\t\"audit-policy-file\": []any{string(\"/var/run/configmaps/audit/audit.\"...)},\n+\u00a0\t\t},\n+\u00a0\t\t\"servingInfo\":
map[string]any{\n+\u00a0\t\t\t\"cipherSuites\": []any{\n+\u00a0\t\t\t\tstring(\"TLS_AES_128_GCM_SHA256\"),
string(\"TLS_AES_256_GCM_SHA384\"),\n+\u00a0\t\t\t\tstring(\"TLS_CHACHA20_POLY1305_SHA256\"),\n+\u00a0\t\t\t\tstring(\"TLS_ECDHE_ECDSA_WITH_AES_128_GCM\"...),
...,\n+\u00a0\t\t\t},\n+\u00a0\t\t\t\"minTLSVersion\": string(\"VersionTLS12\"),\n+\u00a0\t\t},\n+\u00a0\t},\n\u00a0\u00a0)\n"'
metadata:
creationTimestamp: null
name: authentication-operator.17fe72c59b829800.b2cdb588
namespace: openshift-authentication-operator
reason: ObservedConfigChanged
reportingComponent: ""
reportingInstance: ""
source:
component: cluster-authentication-operator-run-once-sync-context
type: Normal
2 changes: 1 addition & 1 deletion ...n-operator.17fe72c59b829800.57eb8535.yaml → ...n-operator.17fe72c59b829800.b2cdb588.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
action: Create
controllerInstanceName: ""
generateName: ""
name: authentication-operator.17fe72c59b829800.57eb8535
name: authentication-operator.17fe72c59b829800.b2cdb588
namespace: openshift-authentication-operator
resourceType:
Group: ""
Expand Down
35 changes: 0 additions & 35 deletions ...ion-operator/core/events/6471-body-authentication-operator.17fe72c59b829800.57eb8535.yaml
View file
Open in desktop

This file was deleted.

25 changes: 25 additions & 0 deletions ...ion-operator/core/events/86b1-body-authentication-operator.17fe72c59b829800.5aa4f723.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
apiVersion: v1
count: 1
eventTime: null
firstTimestamp: "2024-10-14T22:38:20Z"
involvedObject:
kind: Deployment
name: authentication-operator
namespace: openshift-authentication-operator
kind: Event
lastTimestamp: "2024-10-14T22:38:20Z"
message: 'Writing updated section ("oauthAPIServer") of observed config: "\u00a0\u00a0map[string]any(\n-\u00a0\tnil,\n+\u00a0\t{\n+\u00a0\t\t\"apiServerArguments\":
map[string]any{\n+\u00a0\t\t\t\"api-audiences\": []any{string(\"https://kubernetes.default.svc\")},\n+\u00a0\t\t\t\"cors-allowed-origins\":
[]any{string(`//127\\.0\\.0\\.1(:|$)`), string(\"//localhost(:|$)\")},\n+\u00a0\t\t\t\"feature-gates\": []any{},\n+\u00a0\t\t\t\"tls-cipher-suites\":
[]any{\n+\u00a0\t\t\t\tstring(\"TLS_AES_128_GCM_SHA256\"), string(\"TLS_AES_256_GCM_SHA384\"),\n+\u00a0\t\t\t\tstring(\"TLS_CHACHA20_POLY1305_SHA256\"),\n+\u00a0\t\t\t\tstring(\"TLS_ECDHE_ECDSA_WITH_AES_128_GCM\"...),
...,\n+\u00a0\t\t\t},\n+\u00a0\t\t\t\"tls-min-version\": string(\"VersionTLS12\"),\n+\u00a0\t\t},\n+\u00a0\t},\n\u00a0\u00a0)\n"'
metadata:
creationTimestamp: null
name: authentication-operator.17fe72c59b829800.5aa4f723
namespace: openshift-authentication-operator
reason: ObservedConfigChanged
reportingComponent: ""
reportingInstance: ""
source:
component: cluster-authentication-operator-run-once-sync-context
type: Normal
2 changes: 1 addition & 1 deletion ...n-operator.17fe72c59b829800.2a24f1b5.yaml → ...n-operator.17fe72c59b829800.5aa4f723.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
action: Create
controllerInstanceName: ""
generateName: ""
name: authentication-operator.17fe72c59b829800.2a24f1b5
name: authentication-operator.17fe72c59b829800.5aa4f723
namespace: openshift-authentication-operator
resourceType:
Group: ""
Expand Down
28 changes: 0 additions & 28 deletions ...ion-operator/core/events/de10-body-authentication-operator.17fe72c59b829800.2a24f1b5.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...shift-COLON-openshift-authenticator-.yaml → ...shift-COLON-openshift-authenticator-.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
labels:
authentication.openshift.io/csr: openshift-authenticator
spec:
request: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURSBSRVFVRVNULS0tLS0KTUlJQkRUQ0J0QUlCQURCU01WQXdUZ1lEVlFRREUwZHplWE4wWlcwNmMyVnlkbWxqWldGalkyOTFiblE2YjNCbApibk5vYVdaMExXOWhkWFJvTFdGd2FYTmxjblpsY2pwdmNHVnVjMmhwWm5RdFlYVjBhR1Z1ZEdsallYUnZjakJaCk1CTUdCeXFHU000OUFnRUdDQ3FHU000OUF3RUhBMElBQk1RUkx4S1BYZklJZHFYQUlMcmpidHNJRmVTZDRPQW8KNFFZbFAvWGlTTEVpNnJydWRCa2xuVVl1UTM3N2g4Mnh0Vk43QnhLUUkxVWFYeDg2R3hreFgwNmdBREFLQmdncQpoa2pPUFFRREFnTklBREJGQWlBVGUwZjMyQStJa2NSS0djN25zU2dRaytCVXRQejlyWU55TVljNmN2Q3A0QUloCkFOdVI2TFhmcXBOYUYyYTBadzNzdWV0Vms5dElUaXQ3WXlWeE1Ka2dtSHhyCi0tLS0tRU5EIENFUlRJRklDQVRFIFJFUVVFU1QtLS0tLQo=
request: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURSBSRVFVRVNULS0tLS0KTUlJQkREQ0J0QUlCQURCU01WQXdUZ1lEVlFRREUwZHplWE4wWlcwNmMyVnlkbWxqWldGalkyOTFiblE2YjNCbApibk5vYVdaMExXOWhkWFJvTFdGd2FYTmxjblpsY2pwdmNHVnVjMmhwWm5RdFlYVjBhR1Z1ZEdsallYUnZjakJaCk1CTUdCeXFHU000OUFnRUdDQ3FHU000OUF3RUhBMElBQkNOcnd3Tlk4R3dmdEZRTWFsa2IxdExFcFhLcjFHNkcKbE51UDRrYUM1aXFUWWpYTkM5VkxHbmF0Y2tFNGVTbGs5RCsvWU1NQURSMVZjL1BWSGowLzF5bWdBREFLQmdncQpoa2pPUFFRREFnTkhBREJFQWlBNXVQbXE0cCtGWjJjL1dQQXFvbUVLeDAydGRlQXNqTnpFMHJLb1RyZEhLd0lnCkJoR3dyM1N5cUNnWjNHTDA2dm9BcjFCZkFNUnNOWksyS0Z3T0E4WVFhOWc9Ci0tLS0tRU5EIENFUlRJRklDQVRFIFJFUVVFU1QtLS0tLQo=
signerName: kubernetes.io/kube-apiserver-client
usages:
- digital signature
Expand Down
0 ...shift-COLON-openshift-authenticator-.yaml → ...shift-COLON-openshift-authenticator-.yaml
View file
Open in desktop
File renamed without changes.
30 changes: 30 additions & 0 deletions ...tus/cluster-scoped-resources/operator.openshift.io/authentications/5749-body-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
apiVersion: operator.openshift.io/v1
kind: Authentication
metadata:
name: cluster
status:
conditions:
- lastTransitionTime: "2025-08-07T22:38:20Z"
message: no oauth-openshift.openshift-authentication pods available on any node.
reason: NoPod
status: "False"
type: OAuthServerDeploymentAvailable
- lastTransitionTime: "2025-08-01T18:45:36Z"
reason: AsExpected
status: "False"
type: OAuthServerDeploymentDegraded
- lastTransitionTime: "2025-08-07T22:38:20Z"
message: 'deployment/oauth-openshift.openshift-authentication: 0/1 pods have been
updated to the latest generation and 0/1 pods are available'
reason: PodsUpdating
status: "True"
type: OAuthServerDeploymentProgressing
Comment on lines +17 to +21
Copy link

@coderabbitai coderabbitai bot Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix replica math in condition message (0/1 vs replicas: 0).

This status says “0/1 … 0/1 available” while the expected Deployment sets replicas to 0. Align this to 0/0 or change the Deployment to 1 replica; otherwise the test is self-inconsistent and brittle.

Apply one of:

-    message: 'deployment/oauth-openshift.openshift-authentication: 0/1 pods have been
-      updated to the latest generation and 0/1 pods are available'
+    message: 'deployment/oauth-openshift.openshift-authentication: 0/0 pods have been
+      updated to the latest generation and 0/0 pods are available'

…or switch the Deployment to replicas: 1 to match “0/1”.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
message: 'deployment/oauth-openshift.openshift-authentication: 0/1 pods have been
updated to the latest generation and 0/1 pods are available'
reason: PodsUpdating
status: "True"
type: OAuthServerDeploymentProgressing
message: 'deployment/oauth-openshift.openshift-authentication: 0/0 pods have been
updated to the latest generation and 0/0 pods are available'
reason: PodsUpdating
status: "True"
type: OAuthServerDeploymentProgressing
🤖 Prompt for AI Agents 
In
test-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/Management/ApplyStatus/cluster-scoped-resources/operator.openshift.io/authentications/5749-body-cluster.yaml
around lines 17-21, the condition message reports "0/1 pods" while the actual
Deployment replica count is 0; make them consistent by either (A) updating the
condition message to "0/0 pods have been updated to the latest generation and
0/0 pods are available" to reflect replicas: 0, or (B) change the expected
Deployment spec to replicas: 1 so the message "0/1 ... 0/1 available" is
correct—choose one approach and apply that single, consistent fix throughout the
expected output and any related test fixtures.

- lastTransitionTime: "2025-08-01T18:45:36Z"
status: "False"
type: OAuthServerWorkloadDegraded
generations:
- group: apps
lastGeneration: 0
name: oauth-openshift
namespace: openshift-authentication
resource: deployments
9 changes: 9 additions & 0 deletions ...cluster-scoped-resources/operator.openshift.io/authentications/5749-metadata-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
action: ApplyStatus
controllerInstanceName: TODO-deploymentController
fieldManager: OAuthServer-Workload
generateName: ""
name: cluster
resourceType:
Group: operator.openshift.io
Resource: authentications
Version: v1
2 changes: 2 additions & 0 deletions .../cluster-scoped-resources/operator.openshift.io/authentications/5749-options-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fieldManager: OAuthServer-Workload
force: true
22 changes: 22 additions & 0 deletions ...ion-operator/core/events/6672-body-authentication-operator.18599d2230299800.64fe3b99.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
apiVersion: v1
count: 1
eventTime: null
firstTimestamp: "2025-08-07T22:38:20Z"
involvedObject:
kind: Deployment
name: authentication-operator
namespace: openshift-authentication-operator
kind: Event
lastTimestamp: "2025-08-07T22:38:20Z"
message: Created Deployment.apps/oauth-openshift -n openshift-authentication because
it was missing
metadata:
creationTimestamp: null
name: authentication-operator.18599d2230299800.64fe3b99
namespace: openshift-authentication-operator
reason: DeploymentCreated
reportingComponent: ""
reportingInstance: ""
source:
component: cluster-authentication-operator-run-once-sync-context
type: Normal
9 changes: 9 additions & 0 deletions ...operator/core/events/6672-metadata-authentication-operator.18599d2230299800.64fe3b99.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
action: Create
controllerInstanceName: ""
generateName: ""
name: authentication-operator.18599d2230299800.64fe3b99
namespace: openshift-authentication-operator
resourceType:
Group: ""
Resource: events
Version: v1
Loading