MGMT-19102: Add boot device type

[carbonin]

This PR creates an API in the agent inventory and in the agent CR for storing the boot device type. The options for this type are ephemeral when an ISO or ipxe is being used for discovery, or persistent when discovery is being done from the same device we're installing to.

In a follow up PR (after the agent changes are merged to populate this field) this field will be used to determine if install should target the existing root filesystem or a separate device.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

Deployed assisted manually and installed a cluster to a host using the existing root filesystem and also using the ISO from the same assisted deployment. This test included the changes from #7220 as well as the agent changes to populate the new inventory field.

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see [CONTRIBUTING] guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [carbonin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@carbonin: This pull request references MGMT-19102 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This PR creates an API in the agent inventory and in the agent CR for storing the boot device type. The options for this type are ephemeral when an ISO or ipxe is being used for discovery, or persistent when discovery is being done from the same device we're installing to.

In a follow up PR (after the agent changes are merged to populate this field) this field will be used to determine if install should target the existing root filesystem or a separate device.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

Deployed assisted manually and installed a cluster to a host using the existing root filesystem and also using the ISO from the same assisted deployment. This test included the changes from #7220 as well as the agent changes to populate the new inventory field.

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see [CONTRIBUTING] guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (9df3014) to head (13a6480).
Report is 7 commits behind head on master.

Files with missing lines	Patch %	Lines
...nternal/controller/controllers/agent_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7221      +/-   ##
==========================================
+ Coverage   67.89%   68.81%   +0.92%     
==========================================
  Files         298      298              
  Lines       40666    42451    +1785     
==========================================
+ Hits        27609    29213    +1604     
- Misses      10587    10683      +96     
- Partials     2470     2555      +85     

Files with missing lines	Coverage Δ
...nternal/controller/controllers/agent_controller.go	76.17% <0.00%> (-0.07%)	⬇️

... and 5 files with indirect coverage changes

[openshift-ci]

@carbonin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-ai-operator-disconnected-capi	13a6480	link	false	/test edge-e2e-ai-operator-disconnected-capi
ci/prow/okd-scos-e2e-aws-ovn	13a6480	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[paul-maidment]

In my opinion this looks ok. Because of the api-review flag, I think we need to run it past @avishayt

[rccrdpccl]

/lgtm
/hold

holding to give a chance to the rest of reviewers, feel free to unhold

[carbonin]

Removing the hold as it's been a few days with no additional review and this is blocking the rest of this work.

/unhold

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server
This PR has been included in build ose-agent-installer-api-server-container-v4.19.0-202501280040.p0.g261ba06.assembly.stream.el9.
All builds following this will include this PR.