Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature support dep1 #7216

Closed
wants to merge 1 commit into from

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Jan 22, 2025

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
Copy link

openshift-ci bot commented Jan 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2025
Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@eifrach eifrach force-pushed the featureSupportDep1 branch from d6aaad5 to 49bcc5a Compare January 22, 2025 13:05
@eifrach eifrach force-pushed the featureSupportDep1 branch from 49bcc5a to ee3fce7 Compare January 23, 2025 08:52
@eifrach
Copy link
Contributor Author

eifrach commented Jan 23, 2025

/test edge-unit-test
/test edge-lint
/test edge-images

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 8.62069% with 106 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (f913284) to head (ee3fce7).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
internal/featuresupport/features_olm_operators.go 0.00% 39 Missing ⚠️
internal/featuresupport/features_networking.go 0.00% 18 Missing ⚠️
internal/featuresupport/features_misc.go 0.00% 14 Missing ⚠️
internal/operators/common/common.go 0.00% 13 Missing ⚠️
internal/featuresupport/features_platforms.go 0.00% 12 Missing ⚠️
internal/featuresupport/feature_support_level.go 44.44% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7216      +/-   ##
==========================================
- Coverage   67.89%   67.72%   -0.17%     
==========================================
  Files         298      298              
  Lines       40652    40773     +121     
==========================================
+ Hits        27599    27612      +13     
- Misses      10584    10692     +108     
  Partials     2469     2469              
Files with missing lines Coverage Δ
internal/operators/mtv/operator.go 68.75% <100.00%> (+0.32%) ⬆️
internal/featuresupport/feature_support_level.go 82.08% <44.44%> (-14.41%) ⬇️
internal/featuresupport/features_platforms.go 87.12% <0.00%> (-5.51%) ⬇️
internal/operators/common/common.go 53.57% <0.00%> (-46.43%) ⬇️
internal/featuresupport/features_misc.go 81.95% <0.00%> (-6.38%) ⬇️
internal/featuresupport/features_networking.go 81.81% <0.00%> (-5.50%) ⬇️
internal/featuresupport/features_olm_operators.go 72.89% <0.00%> (-8.34%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

openshift-ci bot commented Jan 23, 2025

@eifrach: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-unit-test ee3fce7 link true /test edge-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eifrach eifrach closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants