MGMT-19657: Adding nmstate operator to assisted installer #7215
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zszabo-rh: This pull request references MGMT-19657 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@zszabo-rh: This pull request references MGMT-19657 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XL
openshift-ci
bot
added
the
api-review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7215 +/- ##
==========================================
+ Coverage 67.89% 68.34% +0.44%
==========================================
Files 298 300 +2
Lines 40711 41498 +787
==========================================
+ Hits 27642 28363 +721
- Misses 10592 10614 +22
- Partials 2477 2521 +44
|
zszabo-rh
force-pushed
the
nmstate-operator
branch
from
0783737 to
55b8df7
Compare
internal/operators/nmstate/config.go
Outdated
| // Memory value provided in MiB | ||
| MasterMemory int64 = 100 | ||
| MasterCPU int64 = 1 | ||
| // Memory value provided in MiB | ||
| WorkerMemory int64 = 100 | ||
| WorkerCPU int64 = 1 |
There was a problem hiding this comment.
The operator runs on both Master and Worker nodes?
There was a problem hiding this comment.
Not all components, but for example the handler runs on all nodes
https://github.com/nmstate/kubernetes-nmstate/blob/main/deploy/handler/operator.yaml#L279
There was a problem hiding this comment.
nit: how has this number been calculated? the sum of requests value of the linked manifest doesn't seem to add up to such numbers, however I have no idea if other workloads will be deployed nor what workloads are deployed where.
There was a problem hiding this comment.
The numbers are estimations coming from the nmstate operator devs.
zszabo-rh
force-pushed
the
nmstate-operator
branch
from
55b8df7 to
4008665
Compare
|
/test okd-scos-e2e-aws-ovn |
zszabo-rh
force-pushed
the
nmstate-operator
branch
from
805c632 to
fdf60b8
Compare
| func (feature *NmstateFeature) getIncompatibleArchitectures(_ *string) *[]models.ArchitectureSupportLevelID { | ||
| return &[]models.ArchitectureSupportLevelID{} | ||
| } |
There was a problem hiding this comment.
supports all arch? s390x? ppc64?
There was a problem hiding this comment.
The nmstate operator dev team is not aware of any such limitations, but I will try to get confirmation if this statement is based on actual test results.
There was a problem hiding this comment.
It's regularly tested only on x86, but arm image was also built.
So no test results on most architectures, however there is nothing cpu architecture specific in the operator.
|
/lgtm |
|
/approve |
openshift-ci
bot
added
the
approved
|
/hold waiting for tests |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-metal-assisted-nmstate |
|
@zszabo-rh: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test edge-e2e-metal-assisted-nmstate |
|
/test edge-e2e-ai-operator-ztp |
|
/test edge-e2e-metal-assisted-nmstate |
zszabo-rh
force-pushed
the
nmstate-operator
branch
from
fdf60b8 to
b702893
Compare
|
/test edge-e2e-metal-assisted-nmstate |
|
/test edge-e2e-ai-operator-disconnected-capi edge-e2e-metal-assisted-nmstate |
|
/test edge-e2e-metal-assisted-nmstate |
|
@zszabo-rh: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test edge-e2e-metal-assisted-nmstate-4-17 |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
eranco74
removed
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74, rccrdpccl, zszabo-rh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
@zszabo-rh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 8c40e9d
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
MGMT-19657: Adding nmstate operator to assisted installer
Assisted installer can deploy Kubernetes NMState Operator as part of the virtualization bundle. This new operator is not exposed on UI, so cannot be directly selected by the user.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist