Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-19599: Update get bundles endpoint to return a list of bundles instead of list of bundles names #7213

Merged
merged 1 commit into from
Feb 2, 2025
Merged

MGMT-19599: Update get bundles endpoint to return a list of bundles instead of list of bundles names #7213

merged 1 commit into from
Feb 2, 2025

Conversation

eranco74
Copy link
Contributor

@eranco74 eranco74 commented Jan 21, 2025 •
edited
Loading

This is a followup PR following a review comment #7170 (comment)

  • Should this PR be tested by the reviewer? no
  • Is this PR relying on CI for an e2e test run? yes
  • Should this PR be tested in a specific environment? no
  • Any logs, screenshots, etc that can help with the review process?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025 •
edited by openshift-ci bot
Loading

@eranco74: This pull request references MGMT-19599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This is a followup PR following a review comment #7170 (comment)

  • Should this PR be tested by the reviewer? no
  • Is this PR relying on CI for an e2e test run? yes
  • Should this PR be tested in a specific environment? no
  • Any logs, screenshots, etc that can help with the review process?
$ curl http://10.100.102.50:8090/api/assisted-install/v2/operators/bundles
["virtualization","openshiftai"]
$ curl http://10.100.102.50:8090/api/assisted-install/v2/operators/bundles/openshiftai
{"name":"openshiftai","operators":["serverless","authorino","odf","servicemesh","nvidia-gpu","pipelines","openshift-ai"]}
$ curl http://10.100.102.50:8090/api/assisted-install/v2/operators/bundles/virtualization
{"name":"virtualization","operators":["cnv","mtv","odf"]}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eranco74 eranco74 requested a review from jhernand January 21, 2025 15:34
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2025
@openshift-ci openshift-ci bot requested review from linoyaslan and pastequo January 21, 2025 15:35
@openshift-ci openshift-ci bot added the api-review Categorizes an issue or PR as actively needing an API review. label Jan 21, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025 •
edited by openshift-ci bot
Loading

@eranco74: This pull request references MGMT-19599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This is a followup PR following a review comment #7170 (comment)

  • Should this PR be tested by the reviewer? no
  • Is this PR relying on CI for an e2e test run? yes
  • Should this PR be tested in a specific environment? no
  • Any logs, screenshots, etc that can help with the review process?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhernand
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.93%. Comparing base (aa1aeec) to head (b5a8587).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/operators/manager.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7213   +/-   ##
=======================================
  Coverage   67.93%   67.93%           
=======================================
  Files         300      300           
  Lines       40900    40905    +5     
=======================================
+ Hits        27784    27788    +4     
- Misses      10625    10626    +1     
  Partials     2491     2491
Files with missing lines Coverage Δ
internal/operators/manager.go 78.87% <70.00%> (-0.70%) ⬇️

... and 1 file with indirect coverage changes

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f913284 and 2 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6bdc133 and 1 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6bdc133 and 2 for PR HEAD 5beb875 in total

paul-maidment
paul-maidment reviewed Jan 22, 2025
View reviewed changes
internal/operators/manager_test.go
))
Expect(bundles).To(HaveLen(2))
for _, bundle := range bundles{
Expect(bundle.Name).To(BeElementOf(operatorscommon.BundleVirtualization, operatorscommon.BundleOpenshiftai))
Copy link
Contributor

@paul-maidment paul-maidment Jan 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are no longer simply processing strings but instead processing Bundles, is there anything else we should expect here, I know that the Bundle also have a list of operators for example?

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cc75f5f and 1 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cc75f5f and 2 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9df3014 and 1 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9df3014 and 2 for PR HEAD 5beb875 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9df3014 and 2 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f8e3e31 and 1 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f8e3e31 and 2 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 107f867 and 1 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 107f867 and 2 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dd3c75d and 1 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dd3c75d and 2 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9c9bdec and 1 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8dd62c1 and 0 for PR HEAD 5beb875 in total

@openshift-ci-robot
Copy link

/hold

Revision 5beb875 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@jhernand
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@eranco74
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2025
@eranco74
Copy link
Contributor Author

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2025
@eranco74
MGMT-19599: Update get bundles endpoint to return a list of bundles
b5a8587 
instead of list of bundles names

Signed-off-by: Eran Cohen <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2025
@tsorya
Copy link
Contributor

tsorya commented Feb 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 2, 2025

@eranco74: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b5a8587 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 40b8a82 into openshift:master Feb 2, 2025
20 of 21 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server
This PR has been included in build ose-agent-installer-api-server-container-v4.19.0-202502021506.p0.g40b8a82.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhernand jhernand Awaiting requested review from jhernand

@linoyaslan linoyaslan Awaiting requested review from linoyaslan

@pastequo pastequo Awaiting requested review from pastequo

@paul-maidment paul-maidment Awaiting requested review from paul-maidment

Assignees

@jhernand jhernand

@tsorya tsorya

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eranco74 @openshift-ci-robot @jhernand @tsorya @openshift-bot @paul-maidment @openshift-merge-robot