Skip to content

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Jul 29, 2025

SPLAT-2346

Changes

  • Moved VSphereMultiDisk FeatureGate to GA

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 29, 2025

@vr4manta: This pull request references SPLAT-2346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

SPLAT-2346

Changes

  • Moved VSphereMultiDisk FeatureGate to GA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jul 29, 2025

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2025
@openshift-ci openshift-ci bot requested review from deads2k and everettraven July 29, 2025 14:35
@vr4manta
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 29, 2025

@vr4manta: This pull request references SPLAT-2346 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2025
@vr4manta
Copy link
Contributor Author

/assign @JoelSpeed

@JoelSpeed
Copy link
Contributor

/lgtm

Given this is a vsphere specific feature, and the failures do not look to be associated to gates being broken, I think this is safe to override

/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-serial-techpreview-2of2
/override ci/prow/e2e-aws-serial-2of2

Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-aws-serial-techpreview-2of2

In response to this:

/lgtm

Given this is a vsphere specific feature, and the failures do not look to be associated to gates being broken, I think this is safe to override

/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-serial-techpreview-2of2
/override ci/prow/e2e-aws-serial-2of2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4c1f9af into openshift:master Jul 30, 2025
27 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202507301446.p0.g4c1f9af.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants