CNTRLPLANE-368: improve OIDC field validations for Authentication resources

[everettraven]

Updates some of the validations for OIDC-specific fields in the authentications.config.openshift.io CRD.

Specifically:

• as we discovered in CNTRLPLANE-940: Add CEL expression compile validation for Authentication admission kubernetes#2353 (comment) , the current constraints are to loose and result in excessive expression compile times when used up to the limitations.
• updates the issuerURL constraints to align with those in the KAS: https://github.com/kubernetes/kubernetes/blob/8e6d788887034b799f6c2a86991a68a080bb0576/staging/src/k8s.io/apiserver/pkg/apis/apiserver/validation/validation.go#L158-L184 - this should be safe to ratchet as specifying an invalid value means that the KAS will not successfully rollout

[openshift-ci-robot]

@everettraven: This pull request explicitly references no jira issue.

In response to this:

as we discovered in openshift/kubernetes#2353 (comment) that the current constraints are to loose and result in excessive expression compile times when used up to the limitations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @everettraven! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[everettraven]

This PR may evolve to include additional validation changes.

/hold

[openshift-ci-robot]

@everettraven: This pull request references CNTRLPLANE-368 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

as we discovered in openshift/kubernetes#2353 (comment) that the current constraints are to loose and result in excessive expression compile times when used up to the limitations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@everettraven: This pull request references CNTRLPLANE-368 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Updates some of the validations for OIDC-specific fields in the authentications.config.openshift.io CRD.

Specifically:

• as we discovered in CNTRLPLANE-940: Add CEL expression compile validation for Authentication admission kubernetes#2353 (comment) , the current constraints are to loose and result in excessive expression compile times when used up to the limitations.
• updates the issuerURL constraints to align with those in the KAS: https://github.com/kubernetes/kubernetes/blob/8e6d788887034b799f6c2a86991a68a080bb0576/staging/src/k8s.io/apiserver/pkg/apis/apiserver/validation/validation.go#L158-L184 - this should be safe to ratchet as specifying an invalid value means that the KAS will not successfully rollout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

Are any of these fields embedded in the HostedCluster on HyperShift? I believe they may be.

If they are, we need to be careful about the changes we introduce and how they might impact the HostedCluster API on older API servers (CC @enxebre since we talked about this yesterday)

[everettraven]

Are any of these fields embedded in the HostedCluster on HyperShift? I believe they may be.

Yes, they are.

If they are, we need to be careful about the changes we introduce and how they might impact the HostedCluster API on older API servers

In theory, the ratcheting issuerURL changes should only impact existing HostedCluster instances that are invalid and fail to rollout a valid configuration to the Kube API server.

The tightening of the validations on the CEL expression fields should be safe because the feature-gate that corresponds to those fields is TPNU only for both HCP and OCP.

[everettraven]

/hold cancel

[JoelSpeed]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7605f9b and 2 for PR HEAD 2cfc921 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3315d66 and 1 for PR HEAD 2cfc921 in total

[everettraven]

/retest-required

[openshift-ci]

@everettraven: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	2cfc921	link	false	/test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[everettraven]

/retest-required

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202508072056.p0.ga42cd21.assembly.stream.el9.
All builds following this will include this PR.