Skip to content

MCO-1764: Validation expression for Template in VSphereMachineProviderSpec #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

MCO-1764: Validation expression for Template in VSphereMachineProviderSpec #2374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions machine/v1beta1/types_vsphereprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type VSphereMachineProviderSpec struct {
CredentialsSecret *corev1.LocalObjectReference `json:"credentialsSecret,omitempty"`
// template is the name, inventory path, or instance UUID of the template
// used to clone new machines.
// +kubebuilder:validation:MaxLength=80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The virtual machine name is 80 characters max in length but this field afaik is the path to the virtual machine which would most likely always be greater than 80 characters

cc: @vr4manta

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a limit on this that can be imposed?

Template string `json:"template"`
// workspace describes the workspace to use for the machine.
// +optional
Expand Down