OAPE-232/OCPBUGS-55653: Remove GCPLabelsTags featuregate #2372
Conversation
|
Hello @bharath-b-rh! Some important instructions when contributing to openshift/api: |
openshift-ci-robot
added
jira/valid-reference
|
@bharath-b-rh: This pull request references Jira Issue OCPBUGS-55653, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XXL
|
/cc @barbacbd @JoelSpeed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test e2e-aws-ovn-techpreview |
|
/hold Revision 8fa54b5 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
/retest-required |
|
All the CI jobs are failing with same error with few operators like console, ingress reporting degraded status. I will check the failures in detail next Monday. |
|
There's a panic in Machine API Operator as it is still relying on the GCPLabelsTags feature gate |
|
@JoelSpeed Thank you for pointing out the issue! It is also referenced in both machine-api-operator and installer-aro, which I wasn't aware of. Let me create a PR in both projects to remove the reference. It has references in other projects like hypershift, library-go too but in the tests sample data. I think those can be updated by project owners when api package is updated. |
|
/testwith openshift/machine-api-operator#1385 |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold GCP e2e looks in a bad way Have we removed references to this feature gate from Machine API? Looking at the CAMGI on that run it looks like MAPI never stood up, so possibly there are still references? Edit from Machine API Operator logs itself: |
openshift-ci
bot
added
the
do-not-merge/hold
|
Line No 478 had the feature gate reference earlier. Triggering again to check this was the case. /test e2e-gcp |
|
@JoelSpeed |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test verify-client-go |
|
@bharath-b-rh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 674ad74
into
openshift:master
|
@bharath-b-rh: Jira Issue OCPBUGS-55653: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55653 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
The PR is for removing the
GCPLabelsTagsfeaturegate, which was introduced for managing the new features for configuring GCP Labels and Tags inInfrastructureAPI and referenced in o/operators and o/installer.Featuregate references was removed in openshift operators and openshift installer in v4.18, and removing the featuregate definition in this PR.