-
Notifications
You must be signed in to change notification settings - Fork 562
[release-4.18]: add OnClusterBuilds to default config #2365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.18]: add OnClusterBuilds to default config #2365
Conversation
Hello @cheesesashimi! Some important instructions when contributing to openshift/api: |
Skipping CI for Draft Pull Request. |
Verified using IPI on AWS All MCO e2e OCB test cases pased |
/test e2e-gcp |
@cheesesashimi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I am @craychee and I approve this change. |
+1 |
/override ci/prow/verify-crd-schema /lgtm |
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify, ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c86d806
into
openshift:release-4.18
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
This effectively makes OnClusterBuild no longer require TechPreviewNoUpgrade to be enabled before making use of this feature in 4.18.z. Similar work has already landed in 4.19.