Skip to content

Conversation

cheesesashimi
Copy link
Member

This effectively makes OnClusterBuild no longer require TechPreviewNoUpgrade to be enabled before making use of this feature in 4.18.z. Similar work has already landed in 4.19.

Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

Hello @cheesesashimi! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2025
Copy link
Contributor

openshift-ci bot commented Jun 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 12, 2025
@cheesesashimi cheesesashimi changed the title add OnClusterBuilds to default config [release-4.18]: add OnClusterBuilds to default config Jun 12, 2025
@cheesesashimi cheesesashimi marked this pull request as ready for review June 12, 2025 19:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2025
@openshift-ci openshift-ci bot requested review from deads2k and jkyros June 12, 2025 19:45
@sergiordlr
Copy link

Verified using IPI on AWS

All MCO e2e OCB test cases pased

@cheesesashimi
Copy link
Member Author

/test e2e-gcp

Copy link
Contributor

openshift-ci bot commented Jun 18, 2025

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 34bde19 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp 34bde19 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@craychee
Copy link

craychee commented Jul 8, 2025

I am @craychee and I approve this change.

@nstielau
Copy link

nstielau commented Jul 8, 2025

+1

@JoelSpeed
Copy link
Contributor

/override ci/prow/verify-crd-schema
/override ci/prow/verify

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify, ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema
/override ci/prow/verify

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c86d806 into openshift:release-4.18 Jul 11, 2025
18 of 20 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202507112033.p0.gc86d806.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants