[release-4.16] OCPBUGS-56424: Add IdleConnectionTerminationPolicy field to IngressControllerSpec #2330
Conversation
…ntrollerSpec Add an `IdleConnectionTerminationPolicy` field to control whether HAProxy keeps idle frontend connections open during a soft stop (router reload). Allow users to prevent errors in clients or load balancers that do not properly handle connection resets. This commit is based on openshift#2102 with a key in the default value. For OCP versions <= 4.18, the default is `Deferred`, aligning with older releases where HAProxy’s `idle-close-on-response` option was added unconditionally.
openshift-ci-robot
added
the
jira/severity-critical
|
Hello @alebedev87! Some important instructions when contributing to openshift/api: |
openshift-ci-robot
added
jira/valid-reference
|
@alebedev87: This pull request references Jira Issue OCPBUGS-56424, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/L
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Vendor openshift/api module to get `idleConnectionTerminationPolicy` field of IngressController API.
Vendor steps:
go mod edit -replace github.com/openshift/api=github.com/alebedev87/api@4-16-idle-conn-termination-policy
go mod tidy
go mod vendor
make update
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@lihongan: This pull request references Jira Issue OCPBUGS-56424, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 5c19404
into
openshift:release-4.16
|
@alebedev87: Jira Issue OCPBUGS-56424: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-56424 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Vendor openshift/api module to get `idleConnectionTerminationPolicy` field of IngressController API.
Vendor steps:
go mod edit -replace github.com/openshift/api=github.com/openshift/[email protected]
go mod tidy
go mod vendor
make update
Vendor openshift/api module to get `idleConnectionTerminationPolicy` field of IngressController API.
Vendor steps:
go mod edit -replace github.com/openshift/api=github.com/openshift/[email protected]
go mod tidy
go mod vendor
make update
Manual cherry pick of #2186.