OCPBUGS-55465: Drop on-by-default ValidatingAdmissionPolicy featuregate

[JoelSpeed]

This was inadvertently shipped in 4.17. We will now need to proceed with it as an upstream API removal, which is to be handled by the linked bug.

Once the removal warnings have been put in place, this can then be removed. Putting this up as a placeholder.

NOT to be merged until users cannot upgrade from 4.19 if they are using the v1beta1 version of this API.

/hold

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-55465, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This was inadvertently shipped in 4.17. We will now need to proceed with it as an upstream API removal, which is to be handled by the linked bug.

Once the removal warnings have been put in place, this can then be removed. Putting this up as a placeholder.

NOT to be merged until users cannot upgrade from 4.19 if they are using the v1beta1 version of this API.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[JoelSpeed]

/approve cancel
/jira refresh

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-55465, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/approve cancel
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview	4be19c2	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial-techpreview	4be19c2	link	true	/test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade-out-of-change	4be19c2	link	true	/test e2e-upgrade-out-of-change
ci/prow/e2e-gcp	4be19c2	link	false	/test e2e-gcp
ci/prow/e2e-upgrade	4be19c2	link	true	/test e2e-upgrade
ci/prow/okd-scos-e2e-aws-ovn	4be19c2	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn	4be19c2	link	true	/test e2e-aws-ovn
ci/prow/minor-e2e-upgrade-minor	4be19c2	link	true	/test minor-e2e-upgrade-minor
ci/prow/e2e-azure	4be19c2	link	false	/test e2e-azure
ci/prow/e2e-aws-serial	4be19c2	link	true	/test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.