Skip to content

OCPNODE-3225,OCPNODE-2557: features: set user namespace features on by default #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
+97 −2,423
Merged

OCPNODE-3225,OCPNODE-2557: features: set user namespace features on by default #2305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions features.md
View file
Original file line number Diff line number Diff line change
@@ -48,14 +48,11 @@
| OVNObservability| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| PinnedImages| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| PlatformOperators| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ProcMountType| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| RouteAdvertisements| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| SignatureStores| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| SigstoreImageVerification| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| TranslateStreamCloseWebsocketRequests| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| UpgradeStatus| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| UserNamespacesPodSecurityStandards| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| UserNamespacesSupport| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereConfigurableMaxAllowedBlockVolumesPerNode| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereHostVMGroupZonal| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereMultiDisk| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
@@ -94,9 +91,12 @@
| OpenShiftPodSecurityAdmission| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| PersistentIPsForVirtualization| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| PrivateHostedZoneAWS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ProcMountType| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| RouteExternalCertificate| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ServiceAccountTokenNodeBinding| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| SetEIPForNLBIngressController| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| UserNamespacesPodSecurityStandards| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| UserNamespacesSupport| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereDriverConfiguration| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereMultiVCenters| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ValidatingAdmissionPolicy| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
9 changes: 6 additions & 3 deletions features/features.go
View file
Original file line number Diff line number Diff line change
@@ -687,23 +687,26 @@ var (
contactPerson("haircommander").
productScope(kubernetes).
enhancementPR("https://github.com/kubernetes/enhancements/issues/127").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade, configv1.Default).
mustRegister()

// Note: this feature is perma-alpha, but it is safe and desireable to enable.
// It was an oversight in upstream to not remove the feature gate after the version skew became safe in 1.33.
// See https://github.com/kubernetes/enhancements/tree/d4226c42/keps/sig-node/127-user-namespaces#pod-security-standards-pss-integration
FeatureGateUserNamespacesPodSecurityStandards = newFeatureGate("UserNamespacesPodSecurityStandards").
reportProblemsToJiraComponent("Node").
contactPerson("haircommander").
productScope(kubernetes).
enhancementPR("https://github.com/kubernetes/enhancements/issues/127").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade, configv1.Default).
mustRegister()

FeatureGateProcMountType = newFeatureGate("ProcMountType").
reportProblemsToJiraComponent("Node").
contactPerson("haircommander").
productScope(kubernetes).
enhancementPR("https://github.com/kubernetes/enhancements/issues/4265").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade, configv1.Default).
mustRegister()

FeatureGateVSphereMultiNetworks = newFeatureGate("VSphereMultiNetworks").
391 changes: 0 additions & 391 deletions ...oad-manifests/crds/0000_03_config-operator_01_securitycontextconstraints-Default.crd.yaml
View file

This file was deleted.

403 changes: 0 additions & 403 deletions ...s/crds/0000_03_config-operator_01_securitycontextconstraints-DevPreviewNoUpgrade.crd.yaml
View file

This file was deleted.

403 changes: 0 additions & 403 deletions .../crds/0000_03_config-operator_01_securitycontextconstraints-TechPreviewNoUpgrade.crd.yaml
View file

This file was deleted.

1 change: 0 additions & 1 deletion ...ntextconstraints-CustomNoUpgrade.crd.yaml → ...or_01_securitycontextconstraints.crd.yaml
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,6 @@ metadata:
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
release.openshift.io/bootstrap-required: "true"
release.openshift.io/feature-set: CustomNoUpgrade
name: securitycontextconstraints.security.openshift.io
spec:
group: security.openshift.io
18 changes: 9 additions & 9 deletions payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
View file
Original file line number Diff line number Diff line change
@@ -145,9 +145,6 @@
{
"name": "PlatformOperators"
},
{
"name": "ProcMountType"
},
{
"name": "RouteAdvertisements"
},
@@ -175,12 +172,6 @@
{
"name": "UpgradeStatus"
},
{
"name": "UserNamespacesPodSecurityStandards"
},
{
"name": "UserNamespacesSupport"
},
{
"name": "VSphereConfigurableMaxAllowedBlockVolumesPerNode"
},
@@ -297,6 +288,9 @@
{
"name": "PrivateHostedZoneAWS"
},
{
"name": "ProcMountType"
},
{
"name": "RouteExternalCertificate"
},
@@ -306,6 +300,12 @@
{
"name": "SetEIPForNLBIngressController"
},
{
"name": "UserNamespacesPodSecurityStandards"
},
{
"name": "UserNamespacesSupport"
},
{
"name": "VSphereDriverConfiguration"
},
18 changes: 9 additions & 9 deletions payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
View file
Original file line number Diff line number Diff line change
@@ -145,9 +145,6 @@
{
"name": "PlatformOperators"
},
{
"name": "ProcMountType"
},
{
"name": "RouteAdvertisements"
},
@@ -175,12 +172,6 @@
{
"name": "UpgradeStatus"
},
{
"name": "UserNamespacesPodSecurityStandards"
},
{
"name": "UserNamespacesSupport"
},
{
"name": "VSphereConfigurableMaxAllowedBlockVolumesPerNode"
},
@@ -297,6 +288,9 @@
{
"name": "PrivateHostedZoneAWS"
},
{
"name": "ProcMountType"
},
{
"name": "RouteExternalCertificate"
},
@@ -306,6 +300,12 @@
{
"name": "SetEIPForNLBIngressController"
},
{
"name": "UserNamespacesPodSecurityStandards"
},
{
"name": "UserNamespacesSupport"
},
{
"name": "VSphereDriverConfiguration"
},
73 changes: 70 additions & 3 deletions security/v1/tests/securitycontextconstraints.security.openshift.io/AAA_ungated.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
apiVersion: apiextensions.k8s.io/v1 # Hack because controller-gen complains if we don't have this
name: "SecurityContextConstraints"
crdName: securitycontextconstraints.security.openshift.io
featureGates:
- -UserNamespacesPodSecurityStandards
tests:
onCreate:
- name: Should be able to create a minimal SecurityContextConstraints
- name: Should be able to create a minimal SecurityContextConstraints with featuregate enabled
initial: |
apiVersion: security.openshift.io/v1
kind: SecurityContextConstraints
@@ -35,4 +33,73 @@ tests:
priority: 0
readOnlyRootFilesystem: false
requiredDropCapabilities: []
userNamespaceLevel: "AllowHostLevel"
volumes: []
- name: Should be able to set userNamespaceLevel to AllowHostLevel
initial: |
apiVersion: security.openshift.io/v1
kind: SecurityContextConstraints
userNamespaceLevel: "AllowHostLevel"
allowHostDirVolumePlugin: false
allowHostIPC: false
allowHostNetwork: false
allowHostPID: false
allowHostPorts: false
allowPrivilegedContainer: false
allowedCapabilities: []
defaultAddCapabilities: []
priority: 0
readOnlyRootFilesystem: false
requiredDropCapabilities: []
volumes: []
expected: |
apiVersion: security.openshift.io/v1
kind: SecurityContextConstraints
userNamespaceLevel: "AllowHostLevel"
allowHostDirVolumePlugin: false
allowHostIPC: false
allowHostNetwork: false
allowHostPID: false
allowHostPorts: false
allowPrivilegedContainer: false
allowedCapabilities: []
defaultAddCapabilities: []
priority: 0
readOnlyRootFilesystem: false
requiredDropCapabilities: []
volumes: []
- name: Should be able to set userNamespaceLevel to RequirePodLevel
initial: |
apiVersion: security.openshift.io/v1
kind: SecurityContextConstraints
userNamespaceLevel: "RequirePodLevel"
allowHostDirVolumePlugin: false
allowHostIPC: false
allowHostNetwork: false
allowHostPID: false
allowHostPorts: false
allowPrivilegedContainer: false
allowedCapabilities: []
defaultAddCapabilities: []
priority: 0
readOnlyRootFilesystem: false
requiredDropCapabilities: []
volumes: []
expected: |
apiVersion: security.openshift.io/v1
kind: SecurityContextConstraints
userNamespaceLevel: "RequirePodLevel"
allowHostDirVolumePlugin: false
allowHostIPC: false
allowHostNetwork: false
allowHostPID: false
allowHostPorts: false
allowPrivilegedContainer: false
allowedCapabilities: []
defaultAddCapabilities: []
priority: 0
readOnlyRootFilesystem: false
requiredDropCapabilities: []
volumes: []
391 changes: 0 additions & 391 deletions ...ated.crd-manifests/0000_03_config-operator_01_securitycontextconstraints-Default.crd.yaml
View file

This file was deleted.

403 changes: 0 additions & 403 deletions ...ifests/0000_03_config-operator_01_securitycontextconstraints-DevPreviewNoUpgrade.crd.yaml
View file

This file was deleted.

403 changes: 0 additions & 403 deletions ...fests/0000_03_config-operator_01_securitycontextconstraints-TechPreviewNoUpgrade.crd.yaml
View file

This file was deleted.

1 change: 0 additions & 1 deletion ...ntextconstraints-CustomNoUpgrade.crd.yaml → ...or_01_securitycontextconstraints.crd.yaml
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,6 @@ metadata:
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
release.openshift.io/bootstrap-required: "true"
release.openshift.io/feature-set: CustomNoUpgrade
name: securitycontextconstraints.security.openshift.io
spec:
group: security.openshift.io