Skip to content

Conversation

ShazaAldawamneh
Copy link

Add new fields to the Authentication API

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2025
Copy link
Contributor

openshift-ci bot commented May 2, 2025

Hello @ShazaAldawamneh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed May 2, 2025 11:07
@ShazaAldawamneh ShazaAldawamneh changed the title [WIP]Add missing fields to auth config [WIP]: CNTRLPLANE-311: Add missing fields to auth config May 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2025

@ShazaAldawamneh: This pull request references CNTRLPLANE-311 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Add new fields to the Authentication API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 2, 2025
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new fields will need to go behind a new feature-gate as well.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2025
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2025
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2025
@JoelSpeed
Copy link
Contributor

@ShazaAldawamneh Is this something you're still working on?

@everettraven
Copy link
Contributor

@JoelSpeed I believe this work got put on the backburner for now.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2025
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 18, 2025

@ShazaAldawamneh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 8b450f7 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-serial 8b450f7 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-hypershift a9bdac7 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-gcp a9bdac7 link false /test e2e-gcp
ci/prow/e2e-aws-ovn a9bdac7 link true /test e2e-aws-ovn
ci/prow/e2e-aws-serial-techpreview-2of2 a9bdac7 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-upgrade a9bdac7 link true /test e2e-upgrade
ci/prow/e2e-aws-serial-1of2 a9bdac7 link true /test e2e-aws-serial-1of2
ci/prow/e2e-upgrade-out-of-change a9bdac7 link true /test e2e-upgrade-out-of-change
ci/prow/e2e-aws-serial-techpreview-1of2 a9bdac7 link true /test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-aws-ovn-hypershift-conformance a9bdac7 link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-azure a9bdac7 link false /test e2e-azure
ci/prow/e2e-aws-serial-2of2 a9bdac7 link true /test e2e-aws-serial-2of2
ci/prow/e2e-aws-ovn-techpreview a9bdac7 link true /test e2e-aws-ovn-techpreview
ci/prow/verify 9d04280 link true /test verify
ci/prow/integration 9d04280 link true /test integration
ci/prow/minor-e2e-upgrade-minor 9d04280 link true /test minor-e2e-upgrade-minor
ci/prow/lint 9d04280 link true /test lint
ci/prow/okd-scos-e2e-aws-ovn 9d04280 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants