-
Notifications
You must be signed in to change notification settings - Fork 564
[WIP]: CNTRLPLANE-311: Add missing fields to auth config #2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hello @ShazaAldawamneh! Some important instructions when contributing to openshift/api: |
@ShazaAldawamneh: This pull request references CNTRLPLANE-311 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new fields will need to go behind a new feature-gate as well.
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
@ShazaAldawamneh Is this something you're still working on? |
@JoelSpeed I believe this work got put on the backburner for now. |
Signed-off-by: Shaza Aldawamneh <[email protected]>
…conventions Signed-off-by: Shaza Aldawamneh <[email protected]>
… those fields Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
a9bdac7
to
6e58323
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
Signed-off-by: Shaza Aldawamneh <[email protected]>
@ShazaAldawamneh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add new fields to the Authentication API