Skip to content

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Apr 24, 2025

No description provided.

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

Hello @tkashem! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2025
@openshift-ci openshift-ci bot requested review from deads2k and everettraven April 24, 2025 23:06
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tkashem
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

3 similar comments
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f2f692d0-2163-11f0-9afe-6fe65791d0f1-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c219c780-2448-11f0-9ce0-c67c559db097-0

Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3f17ba80-2462-11f0-8a6f-0a134c946ad2-0

Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5184ad90-2462-11f0-943c-218cbe15a1aa-0

Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a0e22670-24ed-11f0-8f37-af04a0ce20b0-0

Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2c263970-24f7-11f0-9014-d40f30497a8e-0

Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04e602e0-2511-11f0-875a-4d3257975da8-0

Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/046296b0-2540-11f0-9f34-f11e0a81fd28-0

Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4d97ca60-25bf-11f0-9251-9870f906e45a-0

Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/08d6d750-261d-11f0-95b1-fe67a51470d8-0

Copy link
Contributor

openshift-ci bot commented May 1, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71b71bc0-26bf-11f0-8ada-219a5a80228b-0

Copy link
Contributor

openshift-ci bot commented May 2, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0f772e30-2793-11f0-8fbe-c94db7af584d-0

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2025
Copy link
Contributor

openshift-ci bot commented May 4, 2025

@tkashem: This PR was included in a payload test run from openshift/kubernetes#2273
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/beeeb4a0-288d-11f0-8fa5-4c3afe80160d-0

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2025
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 2, 2025
@JoelSpeed
Copy link
Contributor

@tkashem Is this PR still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants