OCPBUGS-44199: Allow spaces in AWS tags

[patrickdillon]

An incorrect regex validation prevents users from specifying AWS tag keys or values that include spaces, which are
allowed by AWS's official regex:

https://docs.aws.amazon.com/directoryservice/latest/devguide/API_Tag.html

This bug is affecting users, so it would be good to backport to at least 4.17.

[openshift-ci]

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-44199, which is invalid:

• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

An incorrect regex validation prevents users from specifying AWS tag keys or values that include spaces, which are
allowed by AWS's official regex:

https://docs.aws.amazon.com/directoryservice/latest/devguide/API_Tag.html

This bug is affecting users, so it would be good to backport to at least 4.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[patrickdillon]

/jira refresh

[openshift-ci-robot]

@patrickdillon: This pull request references Jira Issue OCPBUGS-44199, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/lgtm

[patrickdillon]

@everettraven @JoelSpeed I think the API changes are complete, but I am blocked trying to add tests. I have added a commit with some of the tests I have been experimenting with, but here is what I have found:

1. It seems that specifying a featuregate is required. If I don't specify a featuregate, the tests fail:

the following fields were expected to match but did not:
  [(status.platformStatus.aws.cloudLoadBalancerConfig/status.platformStatus.aws.cloudLoadBalancerConfig)]
  Expected
      <*unstructured.Unstructured | 0xc00008c800>: {
          Object: {
....

Not sure what I should do here, as there is no associated feature gate. Right now I've added an arbitrary feature gate to get the one test I can write to pass. This seems like a bug.

2. Another issue is that when I test the aws:- prefix validation (expected error) with onCreate, I get the same error. So next I try testing with onUpdate. If I put the aws:key key in the initial config, the test fails:

  �[38;5;9m[FAILED] initial object status should update successfully
   ...
              Message: "Infrastructure.config.openshift.io \"test-xw97d\" is invalid: status.platformStatus.aws.resourceTags[0].key: Invalid value: \"string\": the prefix 'aws:' is reserved for AWS system usage and cannot be used at the beginning of a key",

This error message actually demonstrates the validation seems to be working., I just can't figure out a test to confirm it. When I try to update the test so that the bad key is only used during updated, no error is returned. I wonder if this has something to do with how for this object, the values in question are in the status and not the spec?

Please LMK what you think and next steps.

[patrickdillon]

Sorry I missed that this got tagged and ended up needing to rebase.

@JoelSpeed if I could trouble you for another look and lgtm

[patrickdillon]

also it would be fine with me if we want to squash the commits with tide. not sure if there is a preference

[patrickdillon]

/retest

[everettraven]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, everettraven, JoelSpeed, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[everettraven]

Not sure who needs to add the acknowledge-critical-fixes-only label. I suppose @JoelSpeed . Is this change something that would fit the scope of a "critical fix"?

[patrickdillon]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9e59a77 and 2 for PR HEAD d5168f3 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD bf3f3e9 and 1 for PR HEAD d5168f3 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD bf3f3e9 and 2 for PR HEAD d5168f3 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD bf3f3e9 and 2 for PR HEAD d5168f3 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b8a067b and 2 for PR HEAD d5168f3 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b8a067b and 2 for PR HEAD d5168f3 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b8a067b and 2 for PR HEAD d5168f3 in total

[openshift-ci]

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@patrickdillon: Jira Issue OCPBUGS-44199: Some pull requests linked via external trackers have merged:

• openshift/installer#9197
• openshift/release#58746

The following pull requests linked via external trackers have not merged:

• openshift/installer#9315 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-44199 has not been moved to the MODIFIED state.

In response to this:

An incorrect regex validation prevents users from specifying AWS tag keys or values that include spaces, which are
allowed by AWS's official regex:

https://docs.aws.amazon.com/directoryservice/latest/devguide/API_Tag.html

This bug is affecting users, so it would be good to backport to at least 4.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[patrickdillon]

/cherry-pick release-4.18

[openshift-cherrypick-robot]

@patrickdillon: #2124 failed to apply on top of branch "release-4.18":

Applying: OCPBUGS-44199: Allow spaces in AWS resource tags
Using index info to reconstruct a base tree...
M	config/v1/tests/infrastructures.config.openshift.io/AAA_ungated.yaml
M	config/v1/types_infrastructure.go
Falling back to patching base and 3-way merge...
Auto-merging config/v1/types_infrastructure.go
CONFLICT (content): Merge conflict in config/v1/types_infrastructure.go
Auto-merging config/v1/tests/infrastructures.config.openshift.io/AAA_ungated.yaml
CONFLICT (content): Merge conflict in config/v1/tests/infrastructures.config.openshift.io/AAA_ungated.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-44199: Allow spaces in AWS resource tags

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.